Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kusto_cluster: changing regex on ClusterName to match the azure naming convention #23790

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

Dirrbick
Copy link
Contributor

@Dirrbick Dirrbick commented Nov 6, 2023

I am pushing this change as it matches the azure provider naming convention better. I am working on a project that exports resources to create them into Terraform. We came across a name on an Azure Cluster that had a hyphen. When we went to do a plan we got the error that it is required to be Alphanumeric. This is incorrect as I am able to create a cluster in the portal with hyphens. I changed the regex to better align with this.

@Dirrbick Dirrbick changed the title changing regex on ClusterName to match the azure naming convention azurerm_kusto_cluster changing regex on ClusterName to match the azure naming convention Nov 6, 2023
@Dirrbick Dirrbick changed the title azurerm_kusto_cluster changing regex on ClusterName to match the azure naming convention azurerm_kusto_cluster: changing regex on ClusterName to match the azure naming convention Nov 6, 2023
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛈️

@katbyte katbyte merged commit cbe8c39 into hashicorp:main Nov 6, 2023
20 checks passed
@github-actions github-actions bot added this to the v3.80.0 milestone Nov 6, 2023
katbyte added a commit that referenced this pull request Nov 6, 2023
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Nov 10, 2023
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.79.0&#34; to
&#34;3.80.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.80.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.80.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
`internal/sdk` - Added support for pointer Types in resource models
([#23810](hashicorp/terraform-provider-azurerm#23810
dependencies: updating to `v0.63.0` of
`github.com/hashicorp/go-azure-helpers`
([#23785](hashicorp/terraform-provider-azurerm#23785
dependencies: updating to `v0.20231106.1151347` of
`github.com/hashicorp/go-azure-sdk`
([#23787](hashicorp/terraform-provider-azurerm#23787
`azurerm_cognitive_deployment` - support for the
`version_upgrade_option` property
([#22520](hashicorp/terraform-provider-azurerm#22520
`azurerm_firewall_policy_rule_collection_group` - add support for the
property `http_headers`
([#23641](hashicorp/terraform-provider-azurerm#23641
`azurerm_kubernetes_cluster` - `fips_enabled` can be updated in the
`default_node_pool` without recreating the cluster
([#23612](hashicorp/terraform-provider-azurerm#23612
`azurerm_kusto_cluster` - the cluster `name` can now include dashes
([#23790](hashicorp/terraform-provider-azurerm#23790
`azurerm_postgresql_database` - update the validation of `collation` to
include support for `French_France.1252`
([#23783](https://github.com/hashicorp/terraform-provider-azurerm/issues/23783))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* Data Source: `azurerm_data_protection_backup_vault` -
removing `import` support, since Data Sources don&#39;t support being
imported
([#23820](hashicorp/terraform-provider-azurerm#23820
Data Source: `azurerm_kusto_database` - removing `import` support, since
Data Sources don&#39;t support being imported
([#23820](hashicorp/terraform-provider-azurerm#23820
Data Source: `azurerm_virtual_hub_route_table` - removing `import`
support, since Data Sources don&#39;t support being imported
([#23820](https://github.com/hashicorp/terraform-provider-azurerm/issues/23820))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Copy link

github-actions bot commented May 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants