Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ExpressRoute direct MACsec SCI state #23625

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

jake-scott
Copy link
Contributor

Fixes 23624

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jake-scott - I've just left one minor comment on the docs but otherwise this is looking good! Thanks!

website/docs/r/express_route_port.html.markdown Outdated Show resolved Hide resolved
@rcskosir rcskosir linked an issue Oct 20, 2023 that may be closed by this pull request
1 task
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jake-scott LGTM!

@catriona-m catriona-m merged commit de151f9 into hashicorp:main Oct 24, 2023
24 checks passed
@github-actions github-actions bot added this to the v3.78.0 milestone Oct 24, 2023
catriona-m added a commit that referenced this pull request Oct 24, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for SCI state on ExpressRoute Direct ports
2 participants