New Resource `azurerm_resource_management_private_link_association` #23546

teowa · 2023-10-13T06:23:56Z

Private link association (Microsoft.Authorization/privateLinkAssociations)

TF_ACC=1 go test -v ./internal/services/resource -parallel 20 -run TestAccResourceManagementPrivateLinkAssociation -timeout 2h -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccResourceManagementPrivateLinkAssociation_basic
=== PAUSE TestAccResourceManagementPrivateLinkAssociation_basic
=== RUN   TestAccResourceManagementPrivateLinkAssociation_name
=== PAUSE TestAccResourceManagementPrivateLinkAssociation_name
=== RUN   TestAccResourceManagementPrivateLinkAssociation_requiresImport
=== PAUSE TestAccResourceManagementPrivateLinkAssociation_requiresImport
=== CONT  TestAccResourceManagementPrivateLinkAssociation_basic
=== CONT  TestAccResourceManagementPrivateLinkAssociation_requiresImport
=== CONT  TestAccResourceManagementPrivateLinkAssociation_name
--- PASS: TestAccResourceManagementPrivateLinkAssociation_basic (130.37s)
--- PASS: TestAccResourceManagementPrivateLinkAssociation_requiresImport (131.88s)
--- PASS: TestAccResourceManagementPrivateLinkAssociation_name (135.95s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/resource      135.971s

This resource works together with azurerm_resource_management_private_link #23098

catriona-m

Thanks @teowa - I've left a couple of comments inline but once those are addressed we can take another look. Thanks!

catriona-m · 2023-10-16T12:19:57Z

internal/services/resource/resource_management_private_link_association_resource.go

+		"name": {
+			ForceNew:     true,
+			Optional:     true,
+			Computed:     true,
+			Type:         pluginsdk.TypeString,
+			ValidateFunc: validation.IsUUID,
+		},


Given that this is only used as part of the resource id, would it make sense to remove this entirely and rely on the generated uuid here? In any case, as outlined in the contributors guide here we are no longer adding Optional and Computed to new fields.

If remove name entirely, will get test error:

=== CONT TestAccResourceManagementPrivateLinkAssociation_requiresImport testcase.go:113: Step 2/2, expected an error but got none

Can I make name as required to solve this? but in this way user needs to manually set a uuid.

Thanks @teowa. On second thought, we should set this to just Optional and add a note in the docs that the user should use ignore_changes on name if they want to use the generated uuid

catriona-m · 2023-10-16T12:45:57Z

internal/services/resource/resource_management_private_link_association_resource_test.go

+variable "primary_location" {
+  default = %q
+}
+variable "random_string" {
+  default = %q
+}
+variable "random_integer" {
+  default = %d
+}


Given that these seem to be only used once, can we remove these and use the data.Locations.Primary, data.RandomString and data.RandomInteger directly where needed?

fixed, thanks.

catriona-m · 2023-10-16T12:48:32Z

internal/services/resource/resource_management_private_link_association_resource.go

+
+			managementGroupId, err := commonids.ParseManagementGroupID(config.ManagementGroupId)
+			if err != nil {
+				return fmt.Errorf("parse management group id: %+v", err)


Suggested change

return fmt.Errorf("parse management group id: %+v", err)

return err

fixed, thanks.

internal/services/resource/resource_management_private_link_association_resource.go

teowa · 2023-10-24T02:36:32Z

--- PASS: TestAccResourceManagementPrivateLinkAssociation_generateName (51.15s)
--- PASS: TestAccResourceManagementPrivateLinkAssociation_basic (113.61s)
--- PASS: TestAccResourceManagementPrivateLinkAssociation_requiresImport (115.29s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/resource      115.309s

catriona-m

Thanks @teowa LGTM!

github-actions · 2024-05-10T02:12:04Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

teowa added 3 commits October 13, 2023 03:25

new resource private_link_association

526971b

new resource azurerm_resource_management_private_link_association

173eca8

fix

f067dd0

github-actions bot added documentation dependencies size/XL labels Oct 13, 2023

catriona-m requested changes Oct 16, 2023

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Oct 16, 2023

fix

e7018d9

teowa force-pushed the private_link_association branch from c994b85 to e7018d9 Compare October 17, 2023 03:29

github-actions bot removed the waiting-response label Oct 17, 2023

change name as required

8270cd6

github-actions bot added the waiting-response label Oct 20, 2023

change to optional

d397c06

github-actions bot removed the waiting-response label Oct 24, 2023

catriona-m approved these changes Oct 24, 2023

View reviewed changes

catriona-m merged commit d492898 into hashicorp:main Oct 24, 2023
23 checks passed

github-actions bot added this to the v3.78.0 milestone Oct 24, 2023

catriona-m added a commit that referenced this pull request Oct 24, 2023

Update CHANGELOG.md #23546

21af82f

github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource `azurerm_resource_management_private_link_association` #23546

New Resource `azurerm_resource_management_private_link_association` #23546

teowa commented Oct 13, 2023 •

edited

Loading

catriona-m left a comment

catriona-m Oct 16, 2023

teowa Oct 17, 2023 •

edited

Loading

teowa Oct 20, 2023 •

edited

Loading

catriona-m Oct 20, 2023

catriona-m Oct 16, 2023

teowa Oct 20, 2023

catriona-m Oct 16, 2023 •

edited

Loading

teowa Oct 20, 2023

teowa commented Oct 24, 2023

catriona-m left a comment

github-actions bot commented May 10, 2024

	return fmt.Errorf("parse management group id: %+v", err)
	return err

New Resource azurerm_resource_management_private_link_association #23546

New Resource azurerm_resource_management_private_link_association #23546

Conversation

teowa commented Oct 13, 2023 • edited Loading

catriona-m left a comment

Choose a reason for hiding this comment

catriona-m Oct 16, 2023

Choose a reason for hiding this comment

teowa Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

teowa Oct 20, 2023 • edited Loading

Choose a reason for hiding this comment

catriona-m Oct 20, 2023

Choose a reason for hiding this comment

catriona-m Oct 16, 2023

Choose a reason for hiding this comment

teowa Oct 20, 2023

Choose a reason for hiding this comment

catriona-m Oct 16, 2023 • edited Loading

Choose a reason for hiding this comment

teowa Oct 20, 2023

Choose a reason for hiding this comment

teowa commented Oct 24, 2023

catriona-m left a comment

Choose a reason for hiding this comment

github-actions bot commented May 10, 2024

New Resource `azurerm_resource_management_private_link_association` #23546

New Resource `azurerm_resource_management_private_link_association` #23546

teowa commented Oct 13, 2023 •

edited

Loading

teowa Oct 17, 2023 •

edited

Loading

teowa Oct 20, 2023 •

edited

Loading

catriona-m Oct 16, 2023 •

edited

Loading