azurerm_mssql_elasticpool : fix license_type can't be set to null when changing from vCore to DTU model issue

[sinbai]

Per the following behavior of the API, removed the check of TF. Also set a default value when the API does not return a value for license type property to fix issue #22311.

The behavior of the API:

Test results:

[stephybun]

@sinbai per your table the behaviour is that the default value LicenseIncluded isn't returned for the older skus, in which case we should be defaulting it in the read instead of removing Computed from the property.

licenseType := string(sql.LicenseIncluded)
if string(properties.LicenseType) != "" {
  licenseType = string(properties.LicenseType)
}
d.Set("license_type", licenseType)

Could you please make that change?

[sinbai]

@sinbai per your table the behaviour is that the default value LicenseIncluded isn't returned for the older skus, in which case we should be defaulting it in the read instead of removing Computed from the property.

licenseType := string(sql.LicenseIncluded)
if string(properties.LicenseType) != "" {
  licenseType = string(properties.LicenseType)
}
d.Set("license_type", licenseType)

Could you please make that change?

@stephybun thanks for your feedback. Sure. However, after updating code as above and removing the Computed from the property and deleting the ignore_changes of the license_type property, the test case TestAccMsSqlElasticPool_vCoreToStandardDTU fails with the following error:

I assume that for the older skus, the API does not return the default value LicenseIncluded because the API doesn't support specifying it. “Optional + Computed” means we can't set license_type to null. If we don't remove the Computed from the property, which would cause the problem of issue #22311. WDYT? Please feel free to let me know your suggestions.

[stephybun]

@sinbai that error message is coming from the provider, but your table specifies that license_type can be set for all skus so this check can actually be removed?

[sinbai]

@sinbai that error message is coming from the provider, but your table specifies that license_type can be set for all skus so this check can actually be removed?

@stephybun thanks for your suggestion. I have updated the code. All test cases passed in TeamCity. Could you please take another look?

[stephybun]

Thanks @sinbai. Test looks good, one minor thing needs to be fixed but otherwise this should be good to go.

[stephybun]

We don't use underscores in the test config names, can you please remove it and use camelCase like we do everywhere else in the provider

Suggested change

	Config: r.no_licenseType(data),
	Config: r.noLicenseType(data),

[sinbai]

Fixed.

[sinbai]

Thanks @sinbai. Test looks good, one minor thing needs to be fixed but otherwise this should be good to go.

Thank you @stephybun, the name has been updated. Could you please take another look?

[stephybun]

Thanks @sinbai LGTM 🌴

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.