azurerm_web_application_firewall_policy add enabled / disabled state for Custom Rules

[UppyAU]

The azurerm_web_application_firewall_policy resource does not support and is unaware of the State property on the CustomRule present from API Version (2022-09-01).

• This is an issue as you can't add this property to an ignore_changes block on this resource
• Currently the resource does not capture the current state of a custom rule
• Could potentially result in it being re-enabled whilst not indicating so in the terraform plan

Fixes #23123

This is my first PR ever. Please be kind.

[stephybun]

Thanks for this PR @UppyAU.

Although we don't usually expose the enabled field for blocks, after internal discussion we consider it valid in this particular instance.

Overall this looks good, my only request is that we add or extend a test to cover the scenario where the field enabled is toggled. Currently we're only testing the creation of a custom_rule with enabled set to true or false from the get go.

[UppyAU]

TF_ACC=1 go test -v ./internal/services/network -run=TestAccWebApplicationFirewallPolicy_ -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccWebApplicationFirewallPolicy_basic
=== PAUSE TestAccWebApplicationFirewallPolicy_basic
=== RUN   TestAccWebApplicationFirewallPolicy_complete
=== PAUSE TestAccWebApplicationFirewallPolicy_complete
=== RUN   TestAccWebApplicationFirewallPolicy_update
=== PAUSE TestAccWebApplicationFirewallPolicy_update
=== RUN   TestAccWebApplicationFirewallPolicy_updateOverrideRules
=== PAUSE TestAccWebApplicationFirewallPolicy_updateOverrideRules
=== RUN   TestAccWebApplicationFirewallPolicy_knownCVEs
=== PAUSE TestAccWebApplicationFirewallPolicy_knownCVEs
=== RUN   TestAccWebApplicationFirewallPolicy_OperatorAny
=== PAUSE TestAccWebApplicationFirewallPolicy_OperatorAny
=== RUN   TestAccWebApplicationFirewallPolicy_excludedRules
=== PAUSE TestAccWebApplicationFirewallPolicy_excludedRules
=== RUN   TestAccWebApplicationFirewallPolicy_updateDisabledRules
=== PAUSE TestAccWebApplicationFirewallPolicy_updateDisabledRules
=== RUN   TestAccWebApplicationFirewallPolicy_LogScrubbing
=== PAUSE TestAccWebApplicationFirewallPolicy_LogScrubbing
=== RUN   TestAccWebApplicationFirewallPolicy_updateCustomRules
=== PAUSE TestAccWebApplicationFirewallPolicy_updateCustomRules
=== CONT  TestAccWebApplicationFirewallPolicy_basic
=== CONT  TestAccWebApplicationFirewallPolicy_OperatorAny
=== CONT  TestAccWebApplicationFirewallPolicy_updateOverrideRules
=== CONT  TestAccWebApplicationFirewallPolicy_updateCustomRules
=== CONT  TestAccWebApplicationFirewallPolicy_knownCVEs
=== CONT  TestAccWebApplicationFirewallPolicy_LogScrubbing
=== CONT  TestAccWebApplicationFirewallPolicy_updateDisabledRules
=== CONT  TestAccWebApplicationFirewallPolicy_excludedRules
=== CONT  TestAccWebApplicationFirewallPolicy_update
=== CONT  TestAccWebApplicationFirewallPolicy_complete
--- PASS: TestAccWebApplicationFirewallPolicy_OperatorAny (207.53s)
--- PASS: TestAccWebApplicationFirewallPolicy_basic (207.90s)
--- PASS: TestAccWebApplicationFirewallPolicy_LogScrubbing (208.13s)
--- PASS: TestAccWebApplicationFirewallPolicy_complete (211.93s)
--- PASS: TestAccWebApplicationFirewallPolicy_knownCVEs (217.78s)
--- PASS: TestAccWebApplicationFirewallPolicy_update (220.77s)
--- PASS: TestAccWebApplicationFirewallPolicy_updateDisabledRules (229.69s)
--- PASS: TestAccWebApplicationFirewallPolicy_updateCustomRules (234.29s)
--- PASS: TestAccWebApplicationFirewallPolicy_excludedRules (235.12s)
--- PASS: TestAccWebApplicationFirewallPolicy_updateOverrideRules (250.58s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       252.303s

[UppyAU]

Added a test where the each state a rule can be in Enabled, Disabled and Not Set and switching to each of the other possibilities. LMK is that works for you @stephybun

[UppyAU]

Vendor Dependencies Check / depscheck (pull_request) Failing after 53s

Should be fixed by #23235 ?

[stephybun]

@UppyAU could you do a rebase to pull that fix in? I can't run the acceptance tests without it (the GHA on the PR is just our standard CI for linting, unit tests, formatting etc.)

[stephybun]

Thanks for the very thorough test @UppyAU! LGTM 🍰

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.