Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_batch_pool - add new property accelerated_networking_enabled #23160

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

liuwuliuyun
Copy link
Contributor

@liuwuliuyun liuwuliuyun commented Sep 4, 2023

azurerm_batch_pool

  • add new property accelerated_networking_enabled
  • add related document
  • since this property can be used independently, removing Required from subnet_id

Testing evidence:
image

The failed one is not due to this PR and I will try to fix that in a new one.

Comment on lines 1315 to 1318
acceleratedNetworkingEnabled := false
if input.EnableAcceleratedNetworking != nil && *input.EnableAcceleratedNetworking {
acceleratedNetworkingEnabled = true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it defaults to false we can use the pointer.From function further down and get rid of this

Suggested change
acceleratedNetworkingEnabled := false
if input.EnableAcceleratedNetworking != nil && *input.EnableAcceleratedNetworking {
acceleratedNetworkingEnabled = true
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

internal/services/batch/batch_pool.go Outdated Show resolved Hide resolved
@liuwuliuyun
Copy link
Contributor Author

Testing evidence after the change. Testing results on datasource is TBD.

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.2\tmp\GoLand\___TestAccBatchPool_acceleratedNetworkingEnabled_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_batch__1_.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/batch #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.2\tmp\GoLand\___TestAccBatchPool_acceleratedNetworkingEnabled_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_batch__1_.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccBatchPool_acceleratedNetworkingEnabled\E$ #gosetup
=== RUN   TestAccBatchPool_acceleratedNetworkingEnabled
=== PAUSE TestAccBatchPool_acceleratedNetworkingEnabled
=== CONT  TestAccBatchPool_acceleratedNetworkingEnabled
--- PASS: TestAccBatchPool_acceleratedNetworkingEnabled (895.03s)
PASS


Process finished with the exit code 0

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun LGTM 👍

@stephybun stephybun merged commit 87ee7c4 into hashicorp:main Sep 6, 2023
23 checks passed
@github-actions github-actions bot added this to the v3.72.0 milestone Sep 6, 2023
stephybun added a commit that referenced this pull request Sep 7, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants