new resource `azurerm_resource_management_private_link` #23098

teowa · 2023-08-28T09:23:18Z

Resource management private link (Microsoft.Authorization/resourceManagementPrivateLinks)

TF_ACC=1 go test -v ./internal/services/resource -parallel 20 -run TestAccResourceManagementPrivateLink -timeout 2h -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccResourceManagementPrivateLink_basic
=== PAUSE TestAccResourceManagementPrivateLink_basic
=== RUN   TestAccResourceManagementPrivateLink_requiresImport
=== PAUSE TestAccResourceManagementPrivateLink_requiresImport
=== CONT  TestAccResourceManagementPrivateLink_basic
=== CONT  TestAccResourceManagementPrivateLink_requiresImport
--- PASS: TestAccResourceManagementPrivateLink_requiresImport (120.34s)
--- PASS: TestAccResourceManagementPrivateLink_basic (123.63s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/resource      123.647s

tombuildsstuff

hi @teowa

Thanks for this PR - I've taken a look through and left some comments inline, but if we can fix those up we should be able to take another look here.

Thanks!

tombuildsstuff · 2023-09-06T12:25:04Z

internal/services/resource/resource_management_private_link_resource.go

+			if model := resp.Model; model != nil {
+				schema.Name = id.ResourceManagementPrivateLinkName
+				schema.ResourceGroupName = id.ResourceGroupName


the two ID fields don't need to be nil-check'd here fwiw (and we can also move this struct initialization down)

Suggested change

if model := resp.Model; model != nil {

schema.Name = id.ResourceManagementPrivateLinkName

schema.ResourceGroupName = id.ResourceGroupName

schema := ResourceManagementPrivateLinkResourceSchema{

Name: id.ResourceManagementPrivateLinkName,

ResourceGroupName: id.ResourceGroupName,

}

if model := resp.Model; model != nil {

tombuildsstuff · 2023-09-06T13:58:43Z

internal/services/resource/resource_management_private_link_resource.go

+		"private_endpoint_connections": {
+			Computed: true,
+			Elem: &pluginsdk.Schema{
+				Type: pluginsdk.TypeString,
+			},
+			Type: pluginsdk.TypeList,
+		},


Given the nature of this field (the private endpoint connections) this information is likely not going to be useful on the Resource - but could make sense on a Data Source, what's the use-case for exposing this field?

actually we're not setting this in the Read function at all, so can we remove this:

Suggested change

"private_endpoint_connections": {

Computed: true,

Elem: &pluginsdk.Schema{

Type: pluginsdk.TypeString,

},

Type: pluginsdk.TypeList,

},

tombuildsstuff · 2023-09-06T13:59:44Z

internal/services/resource/resource_management_private_link_resource_test.go

+variable "primary_location" {
+  default = %q
+}
+variable "random_integer" {
+  default = %d
+}
+variable "random_string" {
+  default = %q
+}


is this a resource generated via Pandora?

Yes, it is based on Pandora. I have modified the tools/importer to avoid some panic.

tombuildsstuff · 2023-09-06T13:59:58Z

internal/services/resource/resource_management_private_link_resource_test.go

+provider "azurerm" {
+  features {}
+}


the provider block should be in each test, not the template - can we update this

tombuildsstuff · 2023-09-06T14:00:47Z

website/docs/r/resource_management_private_link.html.markdown

+
+* `id` - The ID of the Resource Management Private Link.
+
+* `private_endpoint_connections` - A list of private endpoint connections.


(as above) we likely don't want to expose this field:

Suggested change

* `private_endpoint_connections` - A list of private endpoint connections.

tombuildsstuff · 2023-09-06T14:01:01Z

website/docs/r/resource_management_private_link.html.markdown

@@ -0,0 +1,61 @@
+---
+subcategory: "Management"


this should be within Resources (since it's tied to a Resource Group)

From architecture doc, it is currently only supported at Management Group level, so could we put under Management subcategory?
On the other hand, there is no Resources category:

terraform-provider-azurerm/internal/services/resource/registration.go

Lines 24 to 31 in b4bd986

func (r Registration) WebsiteCategories() []string {

return []string{

"Base",

"Management",

"Template",

}

}

tombuildsstuff · 2023-09-06T14:01:08Z

website/docs/r/resource_management_private_link.html.markdown

+
+# azurerm_resource_management_private_link
+
+Manages a Resource Management Private Link.


can we expand on this

changed to:
Manages a Resource Management Private Link to restrict access for managing resources in the tenant.

tombuildsstuff · 2023-09-06T14:01:10Z

website/docs/r/resource_management_private_link.html.markdown

+layout: "azurerm"
+page_title: "Azure Resource Manager: azurerm_resource_management_private_link"
+description: |-
+  Manages a Resource Management Private Link.


can we expand on this

changed to:
Manages a Resource Management Private Link to restrict access for managing resources in the tenant.

stephybun

@teowa something appears to be wrong with the import test:

------- Stdout: -------
=== RUN   TestAccResourceManagementPrivateLink_requiresImport
=== PAUSE TestAccResourceManagementPrivateLink_requiresImport
=== CONT  TestAccResourceManagementPrivateLink_requiresImport
    testcase.go:113: Step 2/2, expected an error with pattern, no match on: Error running pre-apply refresh: exit status 1
        Error: Duplicate provider configuration
          on terraform_plugin_test.tf line 22:
          22: provider "azurerm" {
        A default (non-aliased) provider configuration for "azurerm" was already
        given at terraform_plugin_test.tf:17,1-19. If multiple configurations are
        required, set the "alias" argument for alternative configurations.
    testing_new.go:79: Error retrieving state, there may be dangling resources: exit status 1

stephybun

Thanks @teowa LGTM 👍

…3114 #23098 #23342 #23329 #23251

<Actions> <action id="4a39167e811ac038e4a588362092472c27cfbe9e4929ae61d035f708a093a669"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.74.0" to "3.75.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.75.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.75.0
FEATURES:

* New Resource: `azurerm_application_load_balancer` ([#22517](hashicorp/terraform-provider-azurerm#22517 New Resource: `azurerm_resource_management_private_link` ([#23098](https://github.com/hashicorp/terraform-provider-azurerm/issues/23098))

ENHANCEMENTS:

* dependencies: `firewall` migrated to `hashicorp/go-azure-sdk` ([#22863](hashicorp/terraform-provider-azurerm#22863 `azurerm_bot_service_azure_bot` - add support for the `icon_url` property ([#23114](hashicorp/terraform-provider-azurerm#23114 `azurerm_cognitive_deployment` - `capacity` property is now updateable ([#23251](hashicorp/terraform-provider-azurerm#23251 `azurerm_container_group` - added support for `key_vault_user_identity_id` ([#23332](hashicorp/terraform-provider-azurerm#23332 `azurerm_data_factory` - added support for the `publish_enabled` property ([#2334](hashicorp/terraform-provider-azurerm#2334 `azurerm_firewall_policy_rule_collection_group` - add support for the `description` property ([#23354](hashicorp/terraform-provider-azurerm#23354 `azurerm_kubernetes_cluster` - `network_profile.network_policy` can be migrated to `cilium` ([#23342](hashicorp/terraform-provider-azurerm#23342 `azurerm_log_analytics_workspace` - add support for the `data_collection_rule_id` property ([#23347](hashicorp/terraform-provider-azurerm#23347 `azurerm_mysql_flexible_server` - add support for the `io_scaling_enabled` property ([#23329](https://github.com/hashicorp/terraform-provider-azurerm/issues/23329))

BUG FIXES:

* `azurerm_api_management_api` - fix importing `openapi` format content file issue ([#23348](hashicorp/terraform-provider-azurerm#23348 `azurerm_cdn_frontdoor_rule` - allow a `cache_duration` of `00:00:00` ([#23384](hashicorp/terraform-provider-azurerm#23384 `azurerm_cosmosdb_cassandra_datacenter` - `sku_name` is now updatable ([#23419](hashicorp/terraform-provider-azurerm#23419 `azurerm_key_vault_certificate` - fix a bug that prevented soft-deleted certificates from being recovered ([#23204](hashicorp/terraform-provider-azurerm#23204 `azurerm_log_analytics_solution` - fix create and update lifecycle of resource by splitting methods ([#23333](hashicorp/terraform-provider-azurerm#23333 `azurerm_management_group_subscription_association` - mark resource as gone correctly if not found when retrieving ([#23335](hashicorp/terraform-provider-azurerm#23335 `azurerm_management_lock` - add polling after create and delete to check for RP propagation ([#23345](hashicorp/terraform-provider-azurerm#23345 `azurerm_monitor_diagnostic_setting` - added validation to ensure at least one of `category` or `category_group` is supplied ([#23308](hashicorp/terraform-provider-azurerm#23308 `azurerm_palo_alto_local_rulestack_prefix_list` - fix rulestack not being committed on delete ([#23362](hashicorp/terraform-provider-azurerm#23362 `azurerm_palo_alto_local_rulestack_fqdn_list` - fix rulestack not being committed on delete ([#23362](hashicorp/terraform-provider-azurerm#23362 `security_center_subscription_pricing_resource` - disabled extensions logic now works as expected ([#22997](https://github.com/hashicorp/terraform-provider-azurerm/issues/22997))



</pre> </details> <details> <summary>3.76.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.76.0
FEATURES:

* New Resource: `azurerm_security_center_storage_defender` ([#23242](hashicorp/terraform-provider-azurerm#23242 New Resource: `azurerm_spring_cloud_application_insights_application_performance_monitoring` ([#23107](https://github.com/hashicorp/terraform-provider-azurerm/issues/23107))

ENHANCEMENTS:

* provider: updating to build using Go `1.21.3` ([#23514](hashicorp/terraform-provider-azurerm#23514 provider: the `roll_instances_when_required` provider feature in the `virtual_machine_scale_set` block is now optional ([#22976](hashicorp/terraform-provider-azurerm#22976 dependencies: updating to `v0.20231012.1141427` of `github.com/hashicorp/go-azure-sdk` ([#23534](hashicorp/terraform-provider-azurerm#23534 Data Source: `azurerm_application_gateway` - support for `backend_http_settings`, `global`, `gateway_ip_configuration` and additional attributes ([#23318](hashicorp/terraform-provider-azurerm#23318 Data Source: `azurerm_network_service_tags` - export the `name` attribute ([#23382](hashicorp/terraform-provider-azurerm#23382 `azurerm_cosmosdb_postgresql_cluster` - add support for `sql_version` of `16` and `citus_version` of `12.1` ([#23476](hashicorp/terraform-provider-azurerm#23476 `azurerm_palo_alto_local_rulestack` - correctly normalize the `location` property ([#23483](hashicorp/terraform-provider-azurerm#23483 `azurerm_static_site` - add support for `app_settings` ([#23421](https://github.com/hashicorp/terraform-provider-azurerm/issues/23421))

BUG FIXES:

* `azurerm_automation_schedule` - fix a bug when updating `start_time` ([#23494](hashicorp/terraform-provider-azurerm#23494 `azurerm_eventhub` - remove ForceNew and check `partition_count` is not decreased ([#23499](hashicorp/terraform-provider-azurerm#23499 `azurerm_managed_lustre_file_system` - update validation for `storage_capacity_in_tb` according to `sku_name` in use ([#23428](hashicorp/terraform-provider-azurerm#23428 `azurerm_virtual_machine` - fix a crash when the API response for the `os_profile` block contains nil properties ([#23535](https://github.com/hashicorp/terraform-provider-azurerm/issues/23535))


</pre> </details> </details> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> --------- Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]> Co-authored-by: Damien Duportal <[email protected]>

github-actions · 2024-05-13T02:11:12Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation dependencies size/XL waiting-response labels Aug 28, 2023

teowa force-pushed the resource_management_private_link branch from 73cc029 to d3c3f54 Compare August 29, 2023 02:50

github-actions bot added waiting-response and removed waiting-response labels Aug 29, 2023

teowa force-pushed the resource_management_private_link branch from d3c3f54 to b4bd986 Compare August 29, 2023 03:01

github-actions bot removed the waiting-response label Aug 29, 2023

tombuildsstuff suggested changes Sep 6, 2023

View reviewed changes

teowa added 2 commits September 7, 2023 12:22

new resource azurerm_resource_management_private_link

5bc03d9

fix review comment

bb47ff3

teowa force-pushed the resource_management_private_link branch from 1803c30 to bb47ff3 Compare September 7, 2023 04:23

fix doc

9ce31e1

stephybun requested changes Sep 21, 2023

View reviewed changes

github-actions bot added the waiting-response label Sep 21, 2023

fix test

f75c73c

github-actions bot removed the waiting-response label Sep 25, 2023

stephybun approved these changes Sep 25, 2023

View reviewed changes

stephybun added new-resource service/resources labels Sep 25, 2023

stephybun merged commit 6f8b827 into hashicorp:main Sep 25, 2023
23 checks passed

github-actions bot added this to the v3.75.0 milestone Sep 25, 2023

stephybun added a commit that referenced this pull request Sep 28, 2023

Update for #23345 #23204 #23344 #23308 #23333 #23332 #23335 #23354 #2…

ff98670

…3114 #23098 #23342 #23329 #23251

teowa mentioned this pull request Oct 13, 2023

New Resource azurerm_resource_management_private_link_association #23546

Merged

atombravo mentioned this pull request Apr 29, 2024

Support for Resource Management Private Link #16929

Open

github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new resource `azurerm_resource_management_private_link` #23098

new resource `azurerm_resource_management_private_link` #23098

teowa commented Aug 28, 2023

tombuildsstuff left a comment

tombuildsstuff Sep 6, 2023

teowa Sep 7, 2023

tombuildsstuff Sep 6, 2023

tombuildsstuff Sep 6, 2023

teowa Sep 7, 2023

tombuildsstuff Sep 6, 2023

teowa Sep 7, 2023

tombuildsstuff Sep 6, 2023

teowa Sep 7, 2023

tombuildsstuff Sep 6, 2023

teowa Sep 7, 2023

tombuildsstuff Sep 6, 2023

teowa Sep 7, 2023

tombuildsstuff Sep 6, 2023

teowa Sep 7, 2023 •

edited

Loading

tombuildsstuff Sep 6, 2023

teowa Sep 7, 2023 •

edited

Loading

stephybun left a comment

stephybun left a comment

github-actions bot commented May 13, 2024


		* `id` - The ID of the Resource Management Private Link.

		* `private_endpoint_connections` - A list of private endpoint connections.

	func (r Registration) WebsiteCategories() []string {
	return []string{
	"Base",
	"Management",
	"Template",
	}
	}


		# azurerm_resource_management_private_link

		Manages a Resource Management Private Link.

new resource azurerm_resource_management_private_link #23098

new resource azurerm_resource_management_private_link #23098

Conversation

teowa commented Aug 28, 2023

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teowa Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teowa Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

stephybun left a comment

Choose a reason for hiding this comment

stephybun left a comment

Choose a reason for hiding this comment

github-actions bot commented May 13, 2024

new resource `azurerm_resource_management_private_link` #23098

new resource `azurerm_resource_management_private_link` #23098

teowa Sep 7, 2023 •

edited

Loading

teowa Sep 7, 2023 •

edited

Loading