Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set bgp_settings to empty array instead of nil #2304

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

JunyiYi
Copy link

@JunyiYi JunyiYi commented Nov 13, 2018

Test cases to:

  • Make sure Computed: true is required
  • Make sure terraform plan has no difference when bgp_settings is nil

This PR fixes #1993 .

@ghost ghost added the size/M label Nov 13, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JunyiYi,

Thanks for the PR, LGTM 👍

@katbyte
Copy link
Collaborator

katbyte commented Nov 14, 2018

tests pass:
screen shot 2018-11-13 at 16 52 21

@katbyte katbyte added this to the 1.19.0 milestone Nov 14, 2018
@katbyte katbyte merged commit d2a15da into master Nov 14, 2018
@katbyte katbyte deleted the vnetgateway_bgpsetting branch November 14, 2018 00:55
katbyte added a commit that referenced this pull request Nov 14, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_network_gateway: bgp_settings
2 participants