Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_group - Support sku and (init_)container.*.security #23034

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Aug 22, 2023

Support the sku and (init_)container.*.security for the azurerm_container_group.

For sku, by default (on absent) it is set to Standard for the existing resources. This meets the most use cases, whilst in order to support the securityContext, it needs to be set to Confidential.

For security block, there are several properties defined in the API. Whilst, currently only the privilege_enabled is supported for all users, the others are behind a feature flag and are only experimental at the current API version (the latest one). Keeping the properties in the security block is a sane choice for the future support once those experimental properties are exposed to public.

Test

💤  TF_ACC=1 go test -v -timeout=20h -run='TestAccContainerGroup_securityContext' ./internal/services/containers
=== RUN   TestAccContainerGroup_securityContext
=== PAUSE TestAccContainerGroup_securityContext
=== CONT  TestAccContainerGroup_securityContext
--- PASS: TestAccContainerGroup_securityContext (279.61s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    279.625s

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor doc comment

website/docs/r/container_group.html.markdown Outdated Show resolved Hide resolved
@mbfrahry mbfrahry added this to the v3.71.0 milestone Aug 23, 2023
@mbfrahry mbfrahry merged commit 339d27e into hashicorp:main Aug 23, 2023
mbfrahry added a commit that referenced this pull request Aug 23, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants