Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor_diagnostic_setting_resource - add deprecation to enable_log retention_policy #23029

Merged

Conversation

HappyTobi
Copy link
Contributor

Hi all,

there is a deprecation that is already in place for "azure diagnostic settings".
So it's not possible to add the retention_policy at the "enabled_log" setting.

Deprecation:
https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/migrate-to-azure-storage-lifecycle-policy

Issue: #23025

Regards
Tobi

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @HappyTobi

@tombuildsstuff tombuildsstuff added this to the v3.72.0 milestone Aug 31, 2023
@tombuildsstuff tombuildsstuff merged commit 16e655e into hashicorp:main Aug 31, 2023
20 checks passed
tombuildsstuff added a commit that referenced this pull request Aug 31, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retention policy days are ignored inside "enabled_log" for azurerm_monitor_diagnostic_setting" module
2 participants