azurerm_key_vault_managed_storage_account - fix TestAccKeyVaultManagedStorageAccount_*
#23022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to block by lagacy functions detection, needs to figure out a different way to address this. |
internal/services/keyvault/key_vault_managed_storage_account.go
Outdated
Show resolved
Hide resolved
…s and exclude the `/` from the BaseURI
tombuildsstuff
approved these changes
Sep 7, 2023
mbfrahry
added a commit
that referenced
this pull request
Sep 7, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is introduced by #22915
Fix TestAccKeyVaultManagedStorageAccount* all of them are failing now.
Root cause: The id needs to be set here is a managed storage account id with format looks like "https://acctestkv-rxfqz.vault.azure.net/storage/acctestKVstorage", not common StorageAccountId.
Fix method: Update the parsing function for two resources when creating and add .ID function for sasToken.
After this fix, all tests besides TestAccKeyVaultManagedStorageAccountSasTokenDefinition_recovery should works. Will track that one in a diff PR.