Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_cognitive_deployment - add locks to parent resource to prevent 409 error for deletes #22940

Merged
merged 6 commits into from
Aug 17, 2023
Merged

azurerm_cognitive_deployment - add locks to parent resource to prevent 409 error for deletes #22940

merged 6 commits into from
Aug 17, 2023

Conversation

aochsner
Copy link
Contributor

@aochsner aochsner commented Aug 14, 2023 •
edited
Loading

defer unlock

Fixes #22939

@aochsner
locks for delete
cc6166f 
defer unlock
@aochsner aochsner changed the title locks for delete azurerm_cognitive_deployment - add locks to parent resource to prevent 409 error for deletes Aug 14, 2023
@liuwuliuyun
Copy link
Contributor

Hi @aochsner , thanks for the contribution. Did you receive 409 error when using read operation? Normally we don't need lock around read function because reading a resource won't change its state. I will handle the delete one with a seperate PR.

@jackofallops jackofallops mentioned this pull request Aug 15, 2023
Closed
jackofallops
jackofallops requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aochsner - One comment to address below and I think we're good to go.

Thanks!

internal/services/cognitive/cognitive_deployment_resource.go Outdated Show resolved Hide resolved
@aochsner
Copy link
Contributor Author

aochsner commented Aug 15, 2023 •
edited
Loading

@jackofallops Thanks! @liuwuliuyun not seeing it on Read...just Create & Delete

stephybun
stephybun requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aochsner, we're nearly there.

internal/services/cognitive/cognitive_deployment_resource.go Outdated Show resolved Hide resolved
stephybun
stephybun approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @aochsner 🌈

@stephybun stephybun merged commit bf83dfd into hashicorp:main Aug 17, 2023
22 checks passed
@github-actions github-actions bot added this to the v3.70.0 milestone Aug 17, 2023
stephybun added a commit that referenced this pull request Aug 17, 2023
@stephybun
Update for #22940
4b1e0fe
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

@jackofallops jackofallops Awaiting requested review from jackofallops

Assignees
No one assigned
Labels
service/cognitive-services size/XS
Projects
None yet
Milestone
v3.70.0
4 participants
@aochsner @liuwuliuyun @jackofallops @stephybun