Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql: reworking the validation for database collation #22928

Merged
merged 2 commits into from
Aug 14, 2023
Merged

postgresql: reworking the validation for database collation #22928

merged 2 commits into from
Aug 14, 2023

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff added this to the v3.70.0 milestone Aug 14, 2023
@tombuildsstuff tombuildsstuff requested a review from a team August 14, 2023 07:51
jackofallops
jackofallops approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 🎣

@jackofallops jackofallops merged commit 57aa65e into main Aug 14, 2023
@jackofallops jackofallops deleted the b/postgresql-collation branch August 14, 2023 13:33
jackofallops added a commit that referenced this pull request Aug 14, 2023
@jackofallops
Update CHANGELOG.md for #22928
d00dc05
@tombuildsstuff tombuildsstuff mentioned this pull request Aug 15, 2023
Closed
1 task
tombuildsstuff added a commit that referenced this pull request Aug 15, 2023
@tombuildsstuff
updating the description for #22928
a016c8d
@mloskot
Copy link
Contributor

mloskot commented Aug 17, 2023

Is there any chance to get this i.e. 3.70 released today yet as planned by August 17, 2023?

mloskot added a commit to mloskot/terraform-azurerm-db-postgresql-flexible that referenced this pull request Feb 22, 2024
@mloskot
fix: Correct casing of default PostgreSQL collation
94e460c 
References:
- hashicorp/terraform-provider-azurerm#22936
- hashicorp/terraform-provider-azurerm#22928

Fixes claranet#3
@mloskot mloskot mentioned this pull request Feb 22, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
bug refactor service/postgresql size/XL
Projects
None yet
Milestone
v3.70.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tombuildsstuff @mloskot @jackofallops