apimanagement : refactoring to use hashicorp/go-azure-sdk

[sinbai]

Test results: There are 8 test cases failed in this test. However, all of them have passed after re-running. See below for details:

https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_APIMANAGEMENT/9967?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildTestsSection=true&expandBuildChangesSection=true

https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_APIMANAGEMENT/10094?buildTab=tests

[tombuildsstuff]

@sinbai heads up I'm looking into the base layer issues the tests have picked up here:

Error: creating/updating Api (Subscription: "*******"
        Resource Group Name: "acctestRG-230803055317928116"
        Service Name: "acctestAM-230803055317928116"
        Api: "acctestAMA-230803055317928116"): performing CreateOrUpdate: no applicable pollers were found for the response

[sinbai]

@sinbai heads up I'm looking into the base layer issues the tests have picked up here:

Error: creating/updating Api (Subscription: "*******"
        Resource Group Name: "acctestRG-230803055317928116"
        Service Name: "acctestAM-230803055317928116"
        Api: "acctestAMA-230803055317928116"): performing CreateOrUpdate: no applicable pollers were found for the response

Hi @tombuildsstuff thanks for letting me know about this. After updating this line to the following code，the test case TestAccApiManagementApiSchema_basic passes on my local. Just letting you know, hope it helps.

statusCodesToCheckProvisioningState := response.StatusCode == http.StatusOK || response.StatusCode == http.StatusCreated || (lroIsSelfReference && response.StatusCode == http.StatusAccepted)

[tombuildsstuff]

@sinbai indeed, that's the same fix I've just pushed a commit to fix :)

[tombuildsstuff]

@sinbai since the fix for this has been merged into hashicorp/go-azure-sdk, can you rebase this PR on top of main?

[sinbai]

@sinbai since the fix for this has been merged into hashicorp/go-azure-sdk, can you rebase this PR on top of main?

Certainly, done:).

[stephybun]

Thanks @sinbai

Looks like there are quite a few new test failures in TC though

[tombuildsstuff]

hashicorp/go-azure-sdk no longer uses Azure/go-autorest for APIManagement - so we can't rely on casting errors using it - can we just check the Status Codes being returned instead?

[sinbai]

@tombuildsstuff thanks for your feedback:). The code has been updated.

[sinbai]

Thanks @sinbai

Looks like there are quite a few new test failures in TC though

@stephybun thanks for your feedback. I have fixed some issues and the code has been updated. Also, I started a new test on Teamcity as follows : https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_APIMANAGEMENT/8397?hideProblemsFromDependencies=false&hideTestsFromDependencies=false.

[sinbai]

Thanks @sinbai

Looks like there are quite a few new test failures in TC though

Hi @stephybun , given the test results in the PR comments, I assume this PR is ready for review, what do you think?

[stephybun]

Thanks @sinbai. I have one comment around assigning the response Model and Properties to variables within the read. We do this for readability, so that we remain consistent could you please update those in all the read methods of the resources/data sources that have been migrated? (I've only pointed out two in-line)

[sinbai]

Thanks @sinbai. I have one comment around assigning the response Model and Properties to variables within the read. We do this for readability, so that we remain consistent could you please update those in all the read methods of the resources/data sources that have been migrated? (I've only pointed out two in-line)

@stephybun thanks for your feedback. Code has been updated. Could you please take another look?

[stephybun]

Thanks for making those changes to bring this in line with the other resources @sinbai. LGTM 🥟

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.