azurerm_site_recovery_replication_recovery_plan: fix update for boot_recovery_group,failover_recovery_group and shutdown_recovery_group
#22687
Conversation
Signed-off-by: ziyeqf <[email protected]>
| @@ -517,14 +517,26 @@ func (r SiteRecoveryReplicationRecoveryPlanResource) Update() sdk.ResourceFunc { | |||
| return fmt.Errorf("parse Site reocvery replication plan id: %+v", err) | |||
| } | |||
|
|
|||
| recoveryPlanGroup, err := expandRecoveryGroup(model.RecoveryGroup) | |||
| if err != nil { | |||
There was a problem hiding this comment.
Move this below the new code and remove the duplicate extra error return code in the if-else structure.
There was a problem hiding this comment.
code updated, thanks
Signed-off-by: ziyeqf <[email protected]>
Signed-off-by: ziyeqf <[email protected]>
There was a problem hiding this comment.
HI @ziyeqf, just left one minor comment here but once that is addressed we can take another look. Thanks!
| if err != nil { | ||
| return fmt.Errorf("when expanding recovery group: %s", err) | ||
| } |
There was a problem hiding this comment.
this can be removed here now too since we aren't expanding the group here anymore
There was a problem hiding this comment.
updated, sorry for that..
Signed-off-by: ziyeqf <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
fix #22649
