Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_managed_lustre_file_system #22680

Merged
merged 34 commits into from
Aug 8, 2023
Merged

New Resource: azurerm_managed_lustre_file_system #22680

merged 34 commits into from
Aug 8, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jul 26, 2023 •
edited
Loading

Service team confirmed this is a completely new and separate product compared to the HPC Cache. So I made it as azurerm_managed_lustre_file_system.

image

@neil-yechenwei neil-yechenwei changed the title New Resource: azurerm_hpc_cache_aml_file_system New Resource: azurerm_aml_file_system Jul 26, 2023
magodo
magodo requested changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

@neil-yechenwei neil-yechenwei changed the title New Resource: azurerm_aml_file_system New Resource: azurerm_managed_lustre_file_system Aug 1, 2023
@neil-yechenwei
Copy link
Contributor Author

@magodo , thanks for the comments. I updated PR. Please take another look. Thanks.

image

@neil-yechenwei neil-yechenwei requested a review from magodo August 2, 2023 02:23
@tombuildsstuff
Copy link
Contributor

FYI - @magodo's fix for the IdentityType issue has been merged / will roll out into hashicorp/go-azure-sdk today: hashicorp/pandora#2872

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Aug 3, 2023 •
edited
Loading

@magodo & @tombuildsstuff , I updated PR for identity. Please take another look. Thanks.

image

stephybun
stephybun requested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei. Overall this looks good, please update the resource with the changes left in-line. Once that's done we this should be good to go.

@neil-yechenwei
Copy link
Contributor Author

@stephybun , thanks for the comments. I updated PR. Please take another look. Thanks.

stephybun
stephybun approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei LGTM 🐨

@stephybun stephybun merged commit 658e0d2 into hashicorp:main Aug 8, 2023
@github-actions github-actions bot added this to the v3.69.0 milestone Aug 8, 2023
stephybun added a commit that referenced this pull request Aug 9, 2023
@stephybun
Update for #22848, #22680, #22519, #22851, #22828, #22733, #22708
c697c30
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

@magodo magodo Awaiting requested review from magodo

Assignees
No one assigned
Labels
dependencies documentation new-resource size/XL
Projects
None yet
Milestone
v3.69.0
Development

Successfully merging this pull request may close these issues.
4 participants
@neil-yechenwei @tombuildsstuff @magodo @stephybun