Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource:] azurerm_databricks_workspace_root_dbfs_customer_managed_key - deprecate azurerm_databricks_workspace_customer_managed_key #22579

Merged
merged 8 commits into from
Aug 22, 2023

Conversation

WodansSon
Copy link
Collaborator

@WodansSon WodansSon commented Jul 18, 2023

In the updated 2023-02-01 version of the Databricks API the field this resource controls/wraps has been re-purposed to manage the root DBFS encryption key.

Given the above mentioned changes in the API, this PR will deprecate the old Databricks CMK resource in favor of the same resource but being renamed to bring its naming more into alignment with it's intended purpose. (e.g., managing the Root DBFS CMK encryption key).

(fixes: #22394)

@WodansSon WodansSon changed the title azurerm_databricks_workspace_customer_managed_key - Remove import check for Root DBFS key [New Resource:] azurerm_databricks_workspace_root_dbfs_customer_managed_key - deprecate azurerm_databricks_workspace_customer_managed_key Jul 21, 2023
@WodansSon WodansSon marked this pull request as ready for review July 21, 2023 19:38
@WodansSon
Copy link
Collaborator Author

image

@katbyte katbyte self-assigned this Jul 24, 2023
@WodansSon
Copy link
Collaborator Author

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌵

@WodansSon WodansSon merged commit cdbcd8b into main Aug 22, 2023
25 checks passed
@WodansSon WodansSon deleted the b_databricks_cmk branch August 22, 2023 22:58
@github-actions github-actions bot added this to the v3.71.0 milestone Aug 22, 2023
WodansSon added a commit that referenced this pull request Aug 22, 2023
katbyte added a commit that referenced this pull request Aug 24, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with azure_databricks_cmk 🏷️ databricks
2 participants