Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_function_app_function - update function app function naming restrictions #22519

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Jul 14, 2023

fix #22294

Updating function app function name restriction to allow it accepts - and _ as api does:
image
image

Copy link

@IT-Knight IT-Knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :) Need also those changes

@IT-Knight
Copy link

Hi, how to ask to review and merge it quicker?)

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiaxyi LGTM 👍

@stephybun stephybun merged commit caf4075 into hashicorp:main Aug 8, 2023
@github-actions github-actions bot added this to the v3.69.0 milestone Aug 8, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_function_app_function does not allow underscore in name but Azure does
3 participants