New Resource: `azurerm_application_load_balancer` #22517

ziyeqf · 2023-07-14T02:59:10Z

Swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/servicenetworking/resource-manager/Microsoft.ServiceNetworking/preview/2023-05-01-preview/TrafficController.json

test

❯ tftest servicenetworking TestAccServiceNetworkingALB      
=== RUN   TestAccServiceNetworkingALB_basic
=== PAUSE TestAccServiceNetworkingALB_basic
=== RUN   TestAccServiceNetworkingALB_complete
=== PAUSE TestAccServiceNetworkingALB_complete
=== RUN   TestAccServiceNetworkingALB_update
=== PAUSE TestAccServiceNetworkingALB_update
=== CONT  TestAccServiceNetworkingALB_basic
=== CONT  TestAccServiceNetworkingALB_update
=== CONT  TestAccServiceNetworkingALB_complete
--- PASS: TestAccServiceNetworkingALB_basic (309.88s)
--- PASS: TestAccServiceNetworkingALB_complete (346.02s)
--- PASS: TestAccServiceNetworkingALB_update (403.06s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/servicenetworking

overall

batch   |   resource type           |   status
1       |   azurerm_alb             |   <- this one
2       |   azurerm_alb_frontend    |
2       |   azurerm_alb_association |

Note

Discussed with service team offline, we use azurerm_alb as an alias to keep the consistent with Powershell and Azure CLI. It is also consistent with the controller deployed into the kubernetes ecosystem.
To create these resources, it needs to manually register Microsoft.servicenetworking resource provider on subscription for now. But it will be not needed in weeks so it was not added to the document.

internal/services/servicenetworking/service_networking_alb_resource.go

website/docs/r/service_networking_alb.html.markdown

Signed-off-by: ziyeqf <[email protected]>

ziyeqf · 2023-08-28T02:44:30Z

kindly ping for another review as the resource has been renamed

website/docs/r/service_networking_application_load_balancer.html.markdown

JackStromberg · 2023-08-28T14:08:35Z

kindly ping for another review as the resource has been renamed

Are there markdown docs for frontends and associations resources as well?

Signed-off-by: ziyeqf <[email protected]>

ziyeqf · 2023-08-29T02:59:57Z

kindly ping for another review as the resource has been renamed

Are there markdown docs for frontends and associations resources as well?

@JackStromberg Because of the dependency I can not submit the following PRs now. But I have created 2 PRs on my fork repo where you can review.
frontend: ziyeqf#1
association: ziyeqf#2

Signed-off-by: ziyeqf <[email protected]>

tombuildsstuff

hi @ziyeqf

I've taken a look through and left some comments inline, mostly to match the functionality offered by/to bring this into line with other resources - it's worth noting that most of these comments are covered in the contributor docs - however if we can fix those comments up then we should be able to take another look and get this merged 👍

Thanks!

internal/services/servicenetworking/client/client.go

internal/services/servicenetworking/service_networking_application_load_balancer_resource.go

...nal/services/servicenetworking/service_networking_application_load_balancer_resource_test.go

website/docs/r/service_networking_application_load_balancer.html.markdown

...nal/services/servicenetworking/service_networking_application_load_balancer_resource_test.go

website/docs/r/service_networking_application_load_balancer.html.markdown

Signed-off-by: ziyeqf <[email protected]>

ziyeqf · 2023-09-15T10:00:49Z

code updated ~~but ConfigurationEndpoints has not been changed as I'm not sure the way to pull the endpoint out.~~

Signed-off-by: ziyeqf <[email protected]>

JackStromberg

Looks good, assuming these will merge as well:
ziyeqf#1
ziyeqf#2

jackofallops

Thanks for the changes @ziyeqf - This LGTM now 👍

<Actions> <action id="4a39167e811ac038e4a588362092472c27cfbe9e4929ae61d035f708a093a669"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.74.0" to "3.75.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.75.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.75.0
FEATURES:

* New Resource: `azurerm_application_load_balancer` ([#22517](hashicorp/terraform-provider-azurerm#22517 New Resource: `azurerm_resource_management_private_link` ([#23098](https://github.com/hashicorp/terraform-provider-azurerm/issues/23098))

ENHANCEMENTS:

* dependencies: `firewall` migrated to `hashicorp/go-azure-sdk` ([#22863](hashicorp/terraform-provider-azurerm#22863 `azurerm_bot_service_azure_bot` - add support for the `icon_url` property ([#23114](hashicorp/terraform-provider-azurerm#23114 `azurerm_cognitive_deployment` - `capacity` property is now updateable ([#23251](hashicorp/terraform-provider-azurerm#23251 `azurerm_container_group` - added support for `key_vault_user_identity_id` ([#23332](hashicorp/terraform-provider-azurerm#23332 `azurerm_data_factory` - added support for the `publish_enabled` property ([#2334](hashicorp/terraform-provider-azurerm#2334 `azurerm_firewall_policy_rule_collection_group` - add support for the `description` property ([#23354](hashicorp/terraform-provider-azurerm#23354 `azurerm_kubernetes_cluster` - `network_profile.network_policy` can be migrated to `cilium` ([#23342](hashicorp/terraform-provider-azurerm#23342 `azurerm_log_analytics_workspace` - add support for the `data_collection_rule_id` property ([#23347](hashicorp/terraform-provider-azurerm#23347 `azurerm_mysql_flexible_server` - add support for the `io_scaling_enabled` property ([#23329](https://github.com/hashicorp/terraform-provider-azurerm/issues/23329))

BUG FIXES:

* `azurerm_api_management_api` - fix importing `openapi` format content file issue ([#23348](hashicorp/terraform-provider-azurerm#23348 `azurerm_cdn_frontdoor_rule` - allow a `cache_duration` of `00:00:00` ([#23384](hashicorp/terraform-provider-azurerm#23384 `azurerm_cosmosdb_cassandra_datacenter` - `sku_name` is now updatable ([#23419](hashicorp/terraform-provider-azurerm#23419 `azurerm_key_vault_certificate` - fix a bug that prevented soft-deleted certificates from being recovered ([#23204](hashicorp/terraform-provider-azurerm#23204 `azurerm_log_analytics_solution` - fix create and update lifecycle of resource by splitting methods ([#23333](hashicorp/terraform-provider-azurerm#23333 `azurerm_management_group_subscription_association` - mark resource as gone correctly if not found when retrieving ([#23335](hashicorp/terraform-provider-azurerm#23335 `azurerm_management_lock` - add polling after create and delete to check for RP propagation ([#23345](hashicorp/terraform-provider-azurerm#23345 `azurerm_monitor_diagnostic_setting` - added validation to ensure at least one of `category` or `category_group` is supplied ([#23308](hashicorp/terraform-provider-azurerm#23308 `azurerm_palo_alto_local_rulestack_prefix_list` - fix rulestack not being committed on delete ([#23362](hashicorp/terraform-provider-azurerm#23362 `azurerm_palo_alto_local_rulestack_fqdn_list` - fix rulestack not being committed on delete ([#23362](hashicorp/terraform-provider-azurerm#23362 `security_center_subscription_pricing_resource` - disabled extensions logic now works as expected ([#22997](https://github.com/hashicorp/terraform-provider-azurerm/issues/22997))



</pre> </details> <details> <summary>3.76.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.76.0
FEATURES:

* New Resource: `azurerm_security_center_storage_defender` ([#23242](hashicorp/terraform-provider-azurerm#23242 New Resource: `azurerm_spring_cloud_application_insights_application_performance_monitoring` ([#23107](https://github.com/hashicorp/terraform-provider-azurerm/issues/23107))

ENHANCEMENTS:

* provider: updating to build using Go `1.21.3` ([#23514](hashicorp/terraform-provider-azurerm#23514 provider: the `roll_instances_when_required` provider feature in the `virtual_machine_scale_set` block is now optional ([#22976](hashicorp/terraform-provider-azurerm#22976 dependencies: updating to `v0.20231012.1141427` of `github.com/hashicorp/go-azure-sdk` ([#23534](hashicorp/terraform-provider-azurerm#23534 Data Source: `azurerm_application_gateway` - support for `backend_http_settings`, `global`, `gateway_ip_configuration` and additional attributes ([#23318](hashicorp/terraform-provider-azurerm#23318 Data Source: `azurerm_network_service_tags` - export the `name` attribute ([#23382](hashicorp/terraform-provider-azurerm#23382 `azurerm_cosmosdb_postgresql_cluster` - add support for `sql_version` of `16` and `citus_version` of `12.1` ([#23476](hashicorp/terraform-provider-azurerm#23476 `azurerm_palo_alto_local_rulestack` - correctly normalize the `location` property ([#23483](hashicorp/terraform-provider-azurerm#23483 `azurerm_static_site` - add support for `app_settings` ([#23421](https://github.com/hashicorp/terraform-provider-azurerm/issues/23421))

BUG FIXES:

* `azurerm_automation_schedule` - fix a bug when updating `start_time` ([#23494](hashicorp/terraform-provider-azurerm#23494 `azurerm_eventhub` - remove ForceNew and check `partition_count` is not decreased ([#23499](hashicorp/terraform-provider-azurerm#23499 `azurerm_managed_lustre_file_system` - update validation for `storage_capacity_in_tb` according to `sku_name` in use ([#23428](hashicorp/terraform-provider-azurerm#23428 `azurerm_virtual_machine` - fix a crash when the API response for the `os_profile` block contains nil properties ([#23535](https://github.com/hashicorp/terraform-provider-azurerm/issues/23535))


</pre> </details> </details> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> --------- Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]> Co-authored-by: Damien Duportal <[email protected]>

github-actions · 2024-05-13T02:10:36Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation dependencies size/XL waiting-response and removed waiting-response labels Jul 14, 2023

tombuildsstuff suggested changes Jul 14, 2023

View reviewed changes

internal/services/servicenetworking/service_networking_alb_resource.go Outdated Show resolved Hide resolved

github-actions bot added the waiting-response label Jul 14, 2023

aristosvo mentioned this pull request Jul 25, 2023

Support for Azure Application Gateway for Containers #22667

Open

1 task

aristosvo reviewed Jul 26, 2023

View reviewed changes

website/docs/r/service_networking_alb.html.markdown Outdated Show resolved Hide resolved

ziyeqf added 4 commits August 24, 2023 10:09

New Resource: azurerm_alb

acfcf6b

Signed-off-by: ziyeqf <[email protected]>

update comments

7936c84

Signed-off-by: ziyeqf <[email protected]>

make generate

3ee9ba1

Signed-off-by: ziyeqf <[email protected]>

rename to azurerm_application_load_balancer

00c7715

Signed-off-by: ziyeqf <[email protected]>

ziyeqf force-pushed the tengzh/alb/alb branch from 9640fbd to 00c7715 Compare August 24, 2023 02:09

github-actions bot added waiting-response and removed waiting-response labels Aug 24, 2023

refresh vendor & website-lint

aece909

Signed-off-by: ziyeqf <[email protected]>

github-actions bot removed the waiting-response label Aug 24, 2023

ziyeqf changed the title ~~New Resource: azurerm_alb~~ New Resource: `azurerm_a撇里擦体哦 Aug 25, 2023

ziyeqf changed the title ~~New Resource: `azurerm_a撇里擦体哦~~ New Resource: azurerm_application_balancer Aug 25, 2023

JackStromberg reviewed Aug 28, 2023

View reviewed changes

website/docs/r/service_networking_application_load_balancer.html.markdown Outdated Show resolved Hide resolved

JackStromberg reviewed Aug 28, 2023

View reviewed changes

website/docs/r/service_networking_application_load_balancer.html.markdown Outdated Show resolved Hide resolved

JackStromberg reviewed Aug 28, 2023

View reviewed changes

website/docs/r/service_networking_application_load_balancer.html.markdown Outdated Show resolved Hide resolved

ziyeqf added 3 commits August 29, 2023 10:09

update md

0dcbcf4

Signed-off-by: ziyeqf <[email protected]>

update test location

5819f79

Signed-off-by: ziyeqf <[email protected]>

rename files

833d27a

Signed-off-by: ziyeqf <[email protected]>

update md

4007bcf

Signed-off-by: ziyeqf <[email protected]>

update md

e4564ca

Signed-off-by: ziyeqf <[email protected]>

ziyeqf requested a review from tombuildsstuff September 15, 2023 04:59

tombuildsstuff suggested changes Sep 15, 2023

View reviewed changes

tombuildsstuff added the waiting-response label Sep 15, 2023

update per review

75ae4af

Signed-off-by: ziyeqf <[email protected]>

github-actions bot removed the waiting-response label Sep 15, 2023

github-actions bot added the waiting-response label Sep 15, 2023

primary_endpoints

1f1c3e2

Signed-off-by: ziyeqf <[email protected]>

github-actions bot removed the waiting-response label Sep 18, 2023

ziyeqf requested a review from tombuildsstuff September 25, 2023 02:48

jackofallops changed the title ~~New Resource: azurerm_application_balancer~~ New Resource: azurerm_application_load_balancer Sep 26, 2023

github-actions bot added the waiting-response label Sep 26, 2023

update per comments

6c0bf1d

Signed-off-by: ziyeqf <[email protected]>

ziyeqf requested a review from JackStromberg September 27, 2023 02:08

github-actions bot removed the waiting-response label Sep 27, 2023

ziyeqf requested a review from jackofallops September 27, 2023 02:08

JackStromberg approved these changes Sep 27, 2023

View reviewed changes

jackofallops approved these changes Sep 27, 2023

View reviewed changes

jackofallops merged commit e1eab1a into hashicorp:main Sep 27, 2023
25 checks passed

github-actions bot added this to the v3.75.0 milestone Sep 27, 2023

jackofallops added a commit that referenced this pull request Sep 27, 2023

Update CHANGELOG.md for #22517

09cadb0

ziyeqf mentioned this pull request Oct 20, 2023

new resource:azurerm_application_load_balancer_subnet_association #23628

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_application_load_balancer` #22517

New Resource: `azurerm_application_load_balancer` #22517

ziyeqf commented Jul 14, 2023 •

edited

Loading

ziyeqf commented Aug 28, 2023

JackStromberg commented Aug 28, 2023

ziyeqf commented Aug 29, 2023

tombuildsstuff left a comment

ziyeqf commented Sep 15, 2023 •

edited

Loading

JackStromberg left a comment

jackofallops left a comment

github-actions bot commented May 13, 2024

New Resource: azurerm_application_load_balancer #22517

New Resource: azurerm_application_load_balancer #22517

Conversation

ziyeqf commented Jul 14, 2023 • edited Loading

test

overall

Note

ziyeqf commented Aug 28, 2023

JackStromberg commented Aug 28, 2023

ziyeqf commented Aug 29, 2023

tombuildsstuff left a comment

Choose a reason for hiding this comment

ziyeqf commented Sep 15, 2023 • edited Loading

JackStromberg left a comment

Choose a reason for hiding this comment

jackofallops left a comment

Choose a reason for hiding this comment

github-actions bot commented May 13, 2024

New Resource: `azurerm_application_load_balancer` #22517

New Resource: `azurerm_application_load_balancer` #22517

ziyeqf commented Jul 14, 2023 •

edited

Loading

ziyeqf commented Sep 15, 2023 •

edited

Loading