Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - deprecate public_network_access_enabled #22478

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Jul 12, 2023

I've confirmed with service team, that this feature is not complete and it will not work as expected.

This PR deprecates this field and this field will not pass to the API.

@stephybun
Copy link
Member

@ms-henglu the API currently still accepts and returns this field, are there plans to remove this field in a future API version? Does setting it cause unexpected side effects or does it just do nothing?

Type: pluginsdk.TypeBool,
Optional: true,
Default: true,
Deprecated: "`public_network_access_enabled` is not functional, will not be passed to the API",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do a better job of explaining why this is being removed? and link to any public information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @katbyte , we got confirmation from the service team that this function is not complete yet and they're working on it.

And there's no public doc about this field.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an explanation provided by AKS team suggesting this property is not fully functional ready.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently AKS adds a new validation to prevent users creating clusters with "public_network_access_enabled=false" and UDR(user defined routing).

Without this PR, when users create new cluster with UDR, they must change "public_network_access_enabled" to true or remove "public_network_access_enabled=false" from this config. This PR make it easier for users to adopt this validation, users don't need to change their config, and the existing clusters won't be affected.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu LGTM 👍

@stephybun stephybun merged commit 3b28707 into hashicorp:main Aug 18, 2023
23 checks passed
@github-actions github-actions bot added this to the v3.71.0 milestone Aug 18, 2023
stephybun added a commit that referenced this pull request Aug 18, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants