-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kubernetes_cluster
- deprecate public_network_access_enabled
#22478
azurerm_kubernetes_cluster
- deprecate public_network_access_enabled
#22478
Conversation
@ms-henglu the API currently still accepts and returns this field, are there plans to remove this field in a future API version? Does setting it cause unexpected side effects or does it just do nothing? |
Type: pluginsdk.TypeBool, | ||
Optional: true, | ||
Default: true, | ||
Deprecated: "`public_network_access_enabled` is not functional, will not be passed to the API", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do a better job of explaining why this is being removed? and link to any public information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @katbyte , we got confirmation from the service team that this function is not complete yet and they're working on it.
And there's no public doc about this field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is an explanation provided by AKS team suggesting this property is not fully functional ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recently AKS adds a new validation to prevent users creating clusters with "public_network_access_enabled=false" and UDR(user defined routing).
Without this PR, when users create new cluster with UDR, they must change "public_network_access_enabled" to true or remove "public_network_access_enabled=false" from this config. This PR make it easier for users to adopt this validation, users don't need to change their config, and the existing clusters won't be affected.
Co-authored-by: stephybun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ms-henglu LGTM 👍
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
I've confirmed with service team, that this feature is not complete and it will not work as expected.
This PR deprecates this field and this field will not pass to the API.