azurerm_kubernetes_cluster - add support for node_os_channel_upgrade
#22187
Conversation
| autoChannelUpgrade := d.Get("automatic_channel_upgrade").(string) | ||
| nodeOsChannelUpgrade := d.Get("node_os_channel_upgrade").(string) | ||
| if autoChannelUpgrade != "" { | ||
| if autoChannelUpgrade == string(managedclusters.UpgradeChannelNodeNegativeimage) && nodeOsChannelUpgrade != string(managedclusters.NodeOSUpgradeChannelNodeImage) { |
There was a problem hiding this comment.
Looks like this wants to be
| if autoChannelUpgrade == string(managedclusters.UpgradeChannelNodeNegativeimage) && nodeOsChannelUpgrade != string(managedclusters.NodeOSUpgradeChannelNodeImage) { | |
| if autoChannelUpgrade == string(managedclusters.UpgradeChannelNodeNegativeimage) && string(managedclusters.NodeOSUpgradeChannelNodeImage) != "" && nodeOsChannelUpgrade != string(managedclusters.NodeOSUpgradeChannelNodeImage) { |
to get around
=== CONT TestAccKubernetesCluster_upgradeChannel
testcase.go:110: Step 5/10 error: Error running apply: exit status 1
Error: `node_os_channel_upgrade` must be set to `NodeImage` if `automatic_channel_upgrade` is set to `node-image`
with azurerm_kubernetes_cluster.test,
on terraform_plugin_test.tf line 22, in resource "azurerm_kubernetes_cluster" "test":
22: resource "azurerm_kubernetes_cluster" "test" {
--- FAIL: TestAccKubernetesCluster_upgradeChannel (795.62s)
There was a problem hiding this comment.
Whoops! Checked the api here and passing in
"autoUpgradeProfile": {
"upgradeChannel": "node-image"
},
returns
"autoUpgradeProfile": {
"upgradeChannel": "node-image",
"nodeOSUpgradeChannel": "NodeImage"
},
So my old comment is wrong
| autoChannelUpgrade := d.Get("automatic_channel_upgrade").(string) | ||
| nodeOsChannelUpgrade := d.Get("node_os_channel_upgrade").(string) | ||
| if autoChannelUpgrade != "" { | ||
| if autoChannelUpgrade == string(managedclusters.UpgradeChannelNodeNegativeimage) && nodeOsChannelUpgrade != string(managedclusters.NodeOSUpgradeChannelNodeImage) { |
There was a problem hiding this comment.
Whoops! Checked the api here and passing in
"autoUpgradeProfile": {
"upgradeChannel": "node-image"
},
returns
"autoUpgradeProfile": {
"upgradeChannel": "node-image",
"nodeOSUpgradeChannel": "NodeImage"
},
So my old comment is wrong
|
Thanks for the review @mbfrahry! Relevant tests are passing so this should be good to merge. |
…de` (hashicorp#22187) * add support for node os upgrade channel * goimports * remove duplicated setting on autoUpgradeProfile * fix tests * reference temp name for rotation properly and try different sku for dedicated host
|
@stephybun @mbfrahry this is a breaking change for anyone who was setting Ideally this can be fixed in a patch release ASAP? |
|
Thanks for pointing this out @stevehipwell. I've opened #22284 to rearrange the validation which should go into the next release. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Tests are still running.
Superseded #21386
Related to #20171