Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies - update compute/gallery* to 2022-03-03 #21999

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Jun 1, 2023

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a test failure:

Error: updating Application Version (Subscription: "*******"
        Resource Group Name: "acctest-compute-230601154225989649"
        Gallery Name: "acctestsig230601154225989649"
        Application Name: "acctest-app-230601154225989649"
        Version Name: "0.0.1"): performing Update: galleryapplicationversions.GalleryApplicationVersionsClient#Update: Failure sending request: StatusCode=0 -- Original Error: Code="BadRequest" Message="Complete set of target locations not specified while updating gallery artifact '0.0.1' and type 'GalleryApplicationVersion'. Deletion of previously replicated locations is not allowed, and you need to specify a complete set of target locations in the update request or specify null or empty set for target regions in the update request or set allow deletion of replicated locations under safety profile property. To figure out complete set of target locations, you can perform a get first on gallery artifact"
        
          with azurerm_gallery_application_version.test,
          on terraform_plugin_test.tf line 60, in resource "azurerm_gallery_application_version" "test":
          60: resource "azurerm_gallery_application_version" "test" {
        

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Jun 6, 2023

Hi @katbyte thanks for reviewing! there is a new property in the new sdk AllowDeletionOfReplicatedLocations which needs to set to true to allow the count of target_region to be decreased.
This property is set to true on Azure Portal as well by default, however when missing in the sdk request, it is set to false, thus need to explicitly set it to true when using the new sdk

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Jun 6, 2023

Updated test result
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☔

@katbyte katbyte merged commit f8c3589 into hashicorp:main Jun 13, 2023
@github-actions github-actions bot added this to the v3.61.0 milestone Jun 13, 2023
katbyte added a commit that referenced this pull request Jun 13, 2023
@myc2h6o myc2h6o deleted the gallery_version branch June 13, 2023 03:18
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants