azurerm_hdinsight_interactive_query_cluster: Removing unsupported acc test
#21981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbfrahry
requested changes
Jun 1, 2023
There was a problem hiding this comment.
Hey @jiaweitao001, it looks like what you've submitted is a breaking change and we should deprecate it for 4.0 instead
| @@ -32,7 +32,7 @@ var hdInsightInteractiveQueryClusterWorkerNodeDefinition = HDInsightNodeDefiniti | |||
| CanSpecifyInstanceCount: true, | |||
| MinInstanceCount: 1, | |||
| CanSpecifyDisks: false, | |||
| CanAutoScaleByCapacity: true, | |||
| CanAutoScaleByCapacity: false, | |||
There was a problem hiding this comment.
This is a breaking change. This used to work which means some people may still have configuration built on it. We should deprecate this instead
There was a problem hiding this comment.
Updated to deprecate in 4.0.
jiaweitao001
force-pushed
the
hdinsight_i_query
branch
from
93664cc to
8d02588
Compare
jiaweitao001
force-pushed
the
hdinsight_i_query
branch
from
8d02588 to
f418271
Compare
mbfrahry
added a commit
that referenced
this pull request
Jun 6, 2023
mbfrahry
added a commit
that referenced
this pull request
Jun 6, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to official doc, hdinsight interactive Query clusters can only be configured for schedule-based scaling, not load-based.
Tests are passing.