Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data.azurerm_linux_web_app, data.azurerm_linux_function_app, data.azurerm_cdn_frontdoor_secret data.azurerm_virtual_machine, data.azurerm_virtual_machine_scale_set: add various properties #21945

Merged
merged 2 commits into from
Jun 1, 2023
Merged

data.azurerm_linux_web_app, data.azurerm_linux_function_app, data.azurerm_cdn_frontdoor_secret data.azurerm_virtual_machine, data.azurerm_virtual_machine_scale_set: add various properties #21945

merged 2 commits into from
Jun 1, 2023

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented May 26, 2023

…ties

mbfrahry
mbfrahry requested changes Jun 1, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, the powerstate doesn't look to be set on these tests

image 
=== CONT  TestAccDataSourceAzureRMVirtualMachine_basicLinux
testcase.go:110: Step 1/1 error: Check failed: Check 6/6 error: data.azurerm_virtual_machine.test: Attribute 'power_state' expected to be set

mbfrahry
mbfrahry approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just had to remove some checks as those tests don't show powerstate

@mbfrahry mbfrahry changed the title vms, vmss, linux function apps, frontdoor: add some datasource proper… data.azurerm_linux_web_app, data.azurerm_linux_function_app, data.azurerm_cdn_frontdoor_secret data.azurerm_virtual_machine, data.azurerm_virtual_machine_scale_set: add various properties Jun 1, 2023
@mbfrahry mbfrahry merged commit fcae70e into main Jun 1, 2023
@mbfrahry mbfrahry deleted the kt/add-useful-datasource-attributes branch June 1, 2023 20:50
@mbfrahry mbfrahry added this to the v3.59.0 milestone Jun 1, 2023
mbfrahry added a commit that referenced this pull request Jun 1, 2023
@mbfrahry
Update CHANGELOG.md for #21945
5b6bdaa
@ppatelmunich ppatelmunich mentioned this pull request Sep 12, 2023
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation service/app-service service/cdn size/L
Projects
None yet
Milestone
v3.59.0
Development

Successfully merging this pull request may close these issues.
2 participants
@katbyte @mbfrahry