Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_spring_cloud_certificate - support for the exclude_private_key property #21942

Merged
merged 3 commits into from
Jun 1, 2023
Merged

azurerm_spring_cloud_certificate - support for the exclude_private_key property #21942

merged 3 commits into from
Jun 1, 2023

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented May 26, 2023 •
edited
Loading

image

tombuildsstuff
tombuildsstuff reviewed May 30, 2023
View reviewed changes
internal/services/springcloud/spring_cloud_certificate_resource_test.go
@@ -145,7 +146,7 @@ data "azurerm_client_config" "current" {
}

data "azuread_service_principal" "test" {
display_name = "Azure Spring Cloud Domain-Management"
display_name = "Azure Spring Cloud Resource Provider"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that a breaking change in the service side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tom,

I've confirmed it with service team that both SP can be used to create a certificate. But how to choose the SP is depending on the use case, in this case - exclude-private_key, it must use Azure Spring Cloud Resource Provider.

Azure Spring Cloud Domain-Management is used in custom domain.

I've updated the example in the document as well.

tombuildsstuff
tombuildsstuff approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but this otherwise LGTM 👍

@katbyte katbyte merged commit bdd7c0e into hashicorp:main Jun 1, 2023
katbyte added a commit that referenced this pull request Jun 1, 2023
@katbyte
Update CHANGELOG.md #21942
7eac0d7
@github-actions github-actions bot added this to the v3.59.0 milestone Jun 1, 2023
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation service/spring size/XS
Projects
None yet
Milestone
v3.59.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-henglu @tombuildsstuff @katbyte