azurerm_resources - Add resource group to output of individual resources.

[marcfor]

The azurerm_resources data source is useful for discovering resources in a subscription. However, in order to be able to use specific data sources for a resource type, we need the name of the resource group the resource exists in. Adding a resource_group_name attribute to each resource in the resources list makes it easy to instantiate a data source for the resulting resources.

Example:

data "azurerm_resources" "virtual_networks" {
  type = "Microsoft.Network/virtualNetworks"
}

data "azurerm_virtual_network" "virtual_networks" {
  for_each = { for v in data.azurerm_resources.virtual_networks.resources : v.id => v }

  name = each.value.name
  resource_group_name = each.value.resource_group_name
}

output "virtual_networks" {
  value = data.azurerm_virtual_network.virtual_networks
}

[tombuildsstuff]

Rather than doing this, can we use this function to parse the Resource Group from the ID? That'd handle the resourceGroups segment differing in casing as required

(note: this does say legacy in the name as we're working to remove this parser, but we'll be replacing this with something else, so using the older method is fine here)

[marcfor]

Hi @tombuildsstuff,

Thanks for the feedback. I'll take a look at ParseAzureResourceID and post here once I've wrapped my head around it and updated the PR.

[marcfor]

Hi @tombuildsstuff , I've updated the pull request to use ParseAzureResourceID as requested

[tombuildsstuff]

hey @marcfor

Thanks for this PR - taking a look through here on the whole this is looking pretty good, but can we update the method being used to parse the Resource Group from the resourceids.ParseAzureResourceID function, rather than doing this regex - since not all resources returned from the API use the casing resourceGroups (although that's what's defined in the API Specification) - as such using this function will alleviate that.

Thanks!

[katbyte]

Thanks @marcfor ! LGTM 🏖️

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.