Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_cosmosdb_postgresql_firewall_rule #21599

Merged
merged 4 commits into from
May 4, 2023
Merged

New Resource: azurerm_cosmosdb_postgresql_firewall_rule #21599

merged 4 commits into from
May 4, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Apr 28, 2023 •
edited
Loading

image

catriona-m
catriona-m requested changes May 3, 2023
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @neil-yechenwei, I left a couple of minor comments inline, but otherwise this is looking pretty good. Thanks!

internal/services/cosmos/cosmosdb_postgresql_firewall_rule_resource.go Outdated Show resolved Hide resolved
internal/services/cosmos/cosmosdb_postgresql_firewall_rule_resource.go Outdated Show resolved Hide resolved
internal/services/cosmos/cosmosdb_postgresql_firewall_rule_resource.go Outdated Show resolved Hide resolved
@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented May 4, 2023 •
edited
Loading

@catriona-m , thanks for the comments. I updated PR. Please take another look. Thanks.

image

@neil-yechenwei neil-yechenwei requested a review from catriona-m May 4, 2023 01:14
catriona-m
catriona-m approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei LGTM!

@catriona-m catriona-m merged commit 4414976 into hashicorp:main May 4, 2023
@github-actions github-actions bot added this to the v3.55.0 milestone May 4, 2023
catriona-m added a commit that referenced this pull request May 4, 2023
@catriona-m
Update CHANGELOG.md for #21599
d720cbb
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v3.55.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catriona-m catriona-m catriona-m approved these changes

Assignees
No one assigned
Labels
dependencies documentation service/cosmosdb size/XL
Projects
None yet
Milestone
v3.55.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neil-yechenwei @catriona-m