Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_dev_test_virtual_network only denies use of public IPs on second apply #2152

Closed
PatrickMcAfee-Eagle opened this issue Oct 24, 2018 · 3 comments

Comments

@PatrickMcAfee-Eagle
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

terraform -v
Terraform v0.11.9

  • provider.azurerm v1.17.0

Affected Resource(s)

  • azurerm_dev_test_virtual_network

Terraform Configuration Files

resource "azurerm_dev_test_lab" "lab" {
  name                = "${lower(var.name)}"
  location            = "${var.location}"
  resource_group_name = "${var.resource_group_name}"
}

resource "azurerm_dev_test_virtual_network" "base_network" {
  name                = "${azurerm_dev_test_lab.lab.name}-base-network"
  lab_name            = "${azurerm_dev_test_lab.lab.name}"
  resource_group_name = "${azurerm_dev_test_lab.lab.resource_group_name}"

  subnet {
    use_public_ip_address           = "Deny"
    use_in_virtual_machine_creation = "Allow"
  }
}

Expected Behavior

Terraform should set "use_public_ip_address" to DENY on the first apply

Actual Behavior

Terraform sets "use_public_ip_address" to DENY on the second run of apply

Steps to Reproduce

  1. terraform apply
  2. terraform plan <-- will show that DENY needs to be set
  3. terraform apply
  4. terraform plan <-- will show that no changes are needed
@katbyte katbyte added this to the Soon milestone Oct 24, 2018
@tombuildsstuff tombuildsstuff modified the milestones: Soon, Being Sorted, 1.19.0 Oct 25, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.19.0, 1.20.0 Nov 13, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.20.0, 1.21.0 Dec 3, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.21.0, Future Jan 10, 2019
@mbfrahry mbfrahry modified the milestones: Future, v1.29.0 May 22, 2019
@mbfrahry
Copy link
Member

Thanks for opening this issue @PatrickMcAfee-Eagle. This has been merged and will make it into the next release 1.29.0

@ghost
Copy link

ghost commented May 26, 2019

This has been released in version 1.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.29.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 22, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants