Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark search keys sensitive #21469

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

buckelij
Copy link
Contributor

This sets the Search Service primary_key and secondary_key values as sensitive so they are redacted from console output. Additionally, this marks the Question Answering custom_question_answering_search_service_key key as sensitive - this key will likely often be set from the primary_key of a terraform-managed Search Service and so it would be redacted, but I think it makes sense to mark the field Sensitive explicitly.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @buckelij CI was failing because the files weren't formatted - this is fixed by running make fmt I hope you don't mind I went ahead and did that for you. Otherwise LGTM 👍

@stephybun stephybun merged commit ad175db into hashicorp:main Apr 19, 2023
@github-actions github-actions bot added this to the v3.53.0 milestone Apr 19, 2023
stephybun added a commit that referenced this pull request Apr 19, 2023
@github-actions
Copy link

This functionality has been released in v3.53.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants