Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Source: azurerm_virtual_network_gateway - support new property private_ip_address #21432

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Data Source: azurerm_virtual_network_gateway - support new property private_ip_address #21432

merged 3 commits into from
Apr 24, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Apr 17, 2023 •
edited
Loading

fixes #21424

image

@neil-yechenwei neil-yechenwei changed the title azurerm_virtual_network_gateway - support new property private_ip_address_id Data Source: azurerm_virtual_network_gateway - support new property private_ip_address_id Apr 17, 2023
@neil-yechenwei neil-yechenwei changed the title Data Source: azurerm_virtual_network_gateway - support new property private_ip_address_id Data Source: azurerm_virtual_network_gateway - support new property private_ip_address Apr 17, 2023
@neil-yechenwei neil-yechenwei requested a review from katbyte April 21, 2023 05:17
@neil-yechenwei
Copy link
Contributor Author

@katbyte ,thanks for your comment. I updated PR. Please take another look. Thanks.

stephybun
stephybun approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei LGTM 🍰

@stephybun stephybun merged commit d7cdfdd into hashicorp:main Apr 24, 2023
@github-actions github-actions bot added this to the v3.54.0 milestone Apr 24, 2023
stephybun added a commit that referenced this pull request Apr 24, 2023
@stephybun
Update for #21432
c3f99b7
@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
documentation enhancement service/network size/XS
Projects
None yet
Milestone
v3.54.0
Development

Successfully merging this pull request may close these issues.

Support for exposing "privateIPAddress" for azurerm_virtual_network_gateway
3 participants
@neil-yechenwei @katbyte @stephybun