Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_configuration_{key|feature} - prelong wait time for the role permission to be done propagated #21337

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Apr 7, 2023

original failure:

------- Stdout: -------
=== RUN   TestAccAppConfigurationKey_requiresImport
=== PAUSE TestAccAppConfigurationKey_requiresImport
=== CONT  TestAccAppConfigurationKey_requiresImport
testcase.go:110: Step 1/2 error: Error running apply: exit status 1
Error: waiting for App Configuration Key "acctest-ackey-230407021123907459" read permission to be propagated: timeout while waiting for state to become 'Error, Exists' (last state: 'Forbidden', timeout: 15m0s)
with azurerm_app_configuration_key.test,
on terraform_plugin_test.tf line 43, in resource "azurerm_app_configuration_key" "test":
43: resource "azurerm_app_configuration_key" "test" {
waiting for App Configuration Key "acctest-ackey-230407021123907459" read
permission to be propagated: timeout while waiting for state to become
'Error, Exists' (last state: 'Forbidden', timeout: 15m0s)
--- FAIL: TestAccAppConfigurationKey_requiresImport (975.21s)
FAIL

Test:
TODO

@teowa
Copy link
Contributor Author

teowa commented Apr 11, 2023

Hi @stephybun, thanks for reviewing this, I have changed the code, please take another look.

@stephybun stephybun added the bug label Apr 11, 2023
stephybun

This comment was marked as outdated.

@stephybun stephybun dismissed their stale review April 11, 2023 11:19

Comments not resolved

@teowa teowa force-pushed the fix_app_conf_key_feature_failed_test branch from ad78fb0 to 51b638a Compare April 12, 2023 05:41
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that up @teowa LGTM 💯

@stephybun stephybun merged commit 973e7a5 into hashicorp:main Apr 12, 2023
@github-actions github-actions bot added this to the v3.52.0 milestone Apr 12, 2023
stephybun added a commit that referenced this pull request Apr 12, 2023
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants