Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_role_definition - Increase the continuous 404 counts on delete to tolerate propagation delay #21151

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Mar 28, 2023

There are intermittent errors caught by the TC test cases like:

testing_new.go:86: Error running post-test destroy, there may be dangling resources: "azurerm_role_definition.test" still exists
--- FAIL: TestAccRoleDefinition_basic (346.42s)

And

testing_new.go:86: Error running post-test destroy, there may be dangling resources: "azurerm_role_definition.test" still exists
--- FAIL: TestAccRoleDefinition_emptyName (324.49s)
FAIL

There isn't really a good way to fully eliminate it, but it appears the current continuous count for 404 is not long enough.

Relating to #18208

@tombuildsstuff tombuildsstuff added this to the v3.50.0 milestone Mar 30, 2023
@tombuildsstuff tombuildsstuff merged commit 5e19aef into hashicorp:main Mar 30, 2023
tombuildsstuff added a commit that referenced this pull request Mar 30, 2023
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants