Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_express_route_circuit- can now set authorization_key during creation #21132

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

xuzhang3
Copy link
Contributor

@xuzhang3 xuzhang3 commented Mar 27, 2023

authorization_key can only be set after Circuit is created

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @xuzhang3

Taking a look through here unfortunately this is pushing the internal provider behaviour onto users, when the Resource itself should be determining how to set this field (which in this case is, Create the thing and then call the Update API to set it) - so rather than pushing this onto users can we fix the Resource to support doing this in a single apply?

Thanks!

website/docs/r/express_route_circuit.html.markdown Outdated Show resolved Hide resolved
@xuzhang3 xuzhang3 changed the title [Document] azurerm_express_route_circuit - Add a note for property authorization_key azurerm_express_route_circuit- authorization_key can only be set after Circuit is created Mar 28, 2023
@xuzhang3
Copy link
Contributor Author

=== RUN   TestAccExpressRouteCircuit11111
=== RUN   TestAccExpressRouteCircuit11111/basic
=== RUN   TestAccExpressRouteCircuit11111/basic/authorizationKey
--- PASS: TestAccExpressRouteCircuit11111 (426.58s)
    --- PASS: TestAccExpressRouteCircuit11111/basic (426.58s)
        --- PASS: TestAccExpressRouteCircuit11111/basic/authorizationKey (426.58s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       436.758s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuzhang3 - LGTM 🗝️

@katbyte katbyte changed the title azurerm_express_route_circuit- authorization_key can only be set after Circuit is created azurerm_express_route_circuit- can now set authorization_key during creation Apr 1, 2023
@katbyte katbyte merged commit a34759d into hashicorp:main Apr 1, 2023
katbyte added a commit that referenced this pull request Apr 1, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot added this to the v3.51.0 milestone Apr 1, 2023
@github-actions
Copy link

This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
@xuzhang3 xuzhang3 deleted the f/er_circuit_doc branch August 14, 2024 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants