New Resource: azurerm_cosmosdb_postgresql_cluster

[neil-yechenwei]

fixes #19375

[neil-yechenwei]

@katbyte , thanks for your comment. I updated PR. Please take another look. Thanks.

[mbfrahry]

Hey @neil-yechenwei. Thanks for this PR. It looks mostly good but there are a few potential crashes and some code we should shrink down if we can.

[mbfrahry]

We shouldn't need to set these values in state if the api isn't returning them

[neil-yechenwei]

TF would fail with below error after it's removed. I remember the colleague from your team previously suggested me to read it from tf file. So I assume we need to keep it.

=== RUN   TestAccCosmosDbPostgreSQLCluster_basic
=== PAUSE TestAccCosmosDbPostgreSQLCluster_basic
=== CONT  TestAccCosmosDbPostgreSQLCluster_basic
    testcase.go:110: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
                
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # azurerm_cosmosdb_postgresql_cluster.test will be updated in-place
          ~ resource "azurerm_cosmosdb_postgresql_cluster" "test" {
              + administrator_login_password         = (sensitive value)
                id                                   = "/subscriptions/xx-xx-xxx-xx/resourceGroups/acctestRG-pshsc-230426160316468761/providers/Microsoft.DBforPostgreSQL/serverGroupsv2/acctestcluster230426160316468761"
                name                                 = "acctestcluster230426160316468761"
                # (15 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.

[mbfrahry]

Oh. That's interesting. I haven't seen that before. I wonder whats going on there. But no worries, we can keep it that way!

[mbfrahry]

And here

[neil-yechenwei]

See above reason

[tombuildsstuff]

@neil-yechenwei this is returned from the API - is this coming back as nil / is this an API bug?

[neil-yechenwei]

@mbfrahry , thanks for your comments. I updated PR. Please take another look. Thanks.

--- PASS: TestAccCosmosDbPostgreSQLCluster_basic (1008.82s)
--- PASS: TestAccCosmosDbPostgreSQLCluster_requiresImport (1110.25s)
--- PASS: TestAccCosmosDbPostgreSQLCluster_withSourceCluster (2897.53s)
--- PASS: TestAccCosmosDbPostgreSQLCluster_update (2622.03s)
--- PASS: TestAccCosmosDbPostgreSQLCluster_complete (974.04s)

[mbfrahry]

LGTM! Thanks for those changes @neil-yechenwei

[github-actions]

This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.