New Resource:azurerm_mobile_network_packet_core_control_plane;New Datasource: azurerm_mobile_network_packet_core_control_plane

[ziyeqf]

re-submit as the original PR(#20730) has been reverted.

test

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/mobilenetwork -run=TestAccMobileNetworkPacketCoreControlPlane -timeout=600m
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_basic
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_basic
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withIneropJSON
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withIneropJSON
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_update
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_update
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_basic
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withIneropJSON
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_update
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_basic (516.13s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withUeMTU (517.12s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withIneropJSON (578.63s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface (579.01s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_requiresImport (602.74s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity (738.94s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_update (795.82s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mobilenetwork 795.887s

[ziyeqf]

@tombuildsstuff do you mind taking a look at this again as it has been updated with comments in #20730

[stephybun]

Thanks for clarifying the purpose of the json property and for renaming it @ziyeqf. I've made a first pass through the code for the resource and left some comments and remarks that need to be addressed - please propagate any changes you make in the resource over to the data source as well. Once that's done we can take another look through.

[ziyeqf]

test after update

❯ TF_ACC=1 go test -v ./internal/services/mobilenetwork -run=TestAccMobileNetworkPacketCoreControlPlane -timeout=600m
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_basic
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_basic
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withInteropJSON
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withInteropJSON
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_requiresImport
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_update
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_update
=== RUN   TestAccMobileNetworkPacketCoreControlPlane_complete
=== PAUSE TestAccMobileNetworkPacketCoreControlPlane_complete
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_basic
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withInteropJSON
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_update
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withUeMTU
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_complete
=== CONT  TestAccMobileNetworkPacketCoreControlPlane_requiresImport
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withInteropJSON (575.57s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withUeMTU (602.95s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_basic (642.91s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withAccessInterface (673.85s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_requiresImport (792.53s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_complete (801.28s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_update (813.48s)
--- PASS: TestAccMobileNetworkPacketCoreControlPlane_withCertificateUserAssignedIdentity (916.91s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mobilenetwork 916.981s

[ziyeqf]

Could you please take another look at this? @stephybun

[stephybun]

Thanks @ziyeqf.

I made another pass through and left some minor comments in-line. Once those are resolved this should be good to go!

[ziyeqf]

kindly ping for another look

[katbyte]

LGTM ☎️

[github-actions]

This functionality has been released in v3.58.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.