Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_mobile_network_packet_core_data_plane;New DataSource: azurerm_mobile_network_packet_core_data_plane #21053

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Mar 21, 2023

over all

order | name 
0     | azurerm_mobile_network                              ✅
1     | azurerm_mobile_network_site                         ✅
1     | azurerm_mobile_network_data_network                 ✅
1     | azurerm_mobile_network_service                      ✅
1     | azurerm_mobile_network_slice                        ✅
1     | azurerm_mobile_network_sim_group                    ✅
2     | azurerm_mobile_network_packet_core_control_plane    ✅
2     | azurerm_mobile_network_sim_policy                   ✅
3     | azurerm_mobile_network_packet_core_data_plane       <- this one
4     | azurerm_mobile_network_attached_data_network        
5     | azurerm_mobile_network_sim        

Test

❯ tftest mobilenetwork TestAccMobileNetworkPacketCoreDataPlane
=== RUN   TestAccMobileNetworkPacketCoreDataPlaneDataSource_complete
=== PAUSE TestAccMobileNetworkPacketCoreDataPlaneDataSource_complete
=== RUN   TestAccMobileNetworkPacketCoreDataPlane_basic
=== PAUSE TestAccMobileNetworkPacketCoreDataPlane_basic
=== RUN   TestAccMobileNetworkPacketCoreDataPlane_withAccessInterface
=== PAUSE TestAccMobileNetworkPacketCoreDataPlane_withAccessInterface
=== RUN   TestAccMobileNetworkPacketCoreDataPlane_requiresImport
=== PAUSE TestAccMobileNetworkPacketCoreDataPlane_requiresImport
=== RUN   TestAccMobileNetworkPacketCoreDataPlane_complete
=== PAUSE TestAccMobileNetworkPacketCoreDataPlane_complete
=== RUN   TestAccMobileNetworkPacketCoreDataPlane_update
=== PAUSE TestAccMobileNetworkPacketCoreDataPlane_update
=== CONT  TestAccMobileNetworkPacketCoreDataPlaneDataSource_complete
=== CONT  TestAccMobileNetworkPacketCoreDataPlane_requiresImport
=== CONT  TestAccMobileNetworkPacketCoreDataPlane_withAccessInterface
=== CONT  TestAccMobileNetworkPacketCoreDataPlane_update
=== CONT  TestAccMobileNetworkPacketCoreDataPlane_complete
=== CONT  TestAccMobileNetworkPacketCoreDataPlane_basic
r--- PASS: TestAccMobileNetworkPacketCoreDataPlaneDataSource_complete (702.24s)
--- PASS: TestAccMobileNetworkPacketCoreDataPlane_requiresImport (729.92s)
--- PASS: TestAccMobileNetworkPacketCoreDataPlane_withAccessInterface (730.98s)
--- PASS: TestAccMobileNetworkPacketCoreDataPlane_basic (752.58s)
--- PASS: TestAccMobileNetworkPacketCoreDataPlane_complete (822.84s)
--- PASS: TestAccMobileNetworkPacketCoreDataPlane_update (1036.32s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mobilenetwork 1036.391s

@tombuildsstuff
Copy link
Contributor

@ziyeqf similar to #20730 there's some design issues with this resource, we'll need to fix those before proceeding, however since #20730 depends on this I'm going to mark this as Blocked for the moment

@tombuildsstuff
Copy link
Contributor

@ziyeqf see this comment for the issues in the last PR which'll block (and likely apply to) this PR too.

…aSource: `azurerm_mobile_network_packet_core_data_plane`

Signed-off-by: ziyeqf <[email protected]>
@ziyeqf
Copy link
Contributor Author

ziyeqf commented May 26, 2023

As the dependent one is merged this is unblocked and ready to review.

Signed-off-by: ziyeqf <[email protected]>
@katbyte katbyte merged commit 0022165 into hashicorp:main Jun 13, 2023
katbyte added a commit that referenced this pull request Jun 13, 2023
@katbyte
Copy link
Collaborator

katbyte commented Jun 13, 2023

LGTM 🤖

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants