pollers: accounting for dropped connections #20670
Conversation
It's possible that the connection can be dropped whilst polling, if this is the case then a nil *http.HttpResponse will be returned (since there's no response) - as such we need to use the `response.WasNotFound` (and similar) methods when checking the HTTP Status Code which take dropped connections into account
tombuildsstuff
force-pushed
the
b/nil-http-responses
branch
from
23afc74 to
f5eb223
Compare
There was a problem hiding this comment.
Thank @tombuildsstuff - One minor comment, otherwise LGTM 👍
| "testing" | ||
|
|
||
| "github.com/hashicorp/go-azure-helpers/lang/response" | ||
|
|
|
This functionality has been released in v3.46.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
It's possible that the connection can be dropped whilst polling, if this is the case then a nil *http.HttpResponse will be returned (since there's no response) - as such we need to use the
response.WasNotFound(and similar) methods when checking the HTTP Status Code which take dropped connections into account