Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_batch_pool - fix accessing azure_blob_file_system with user_identity assigned. #20560

Merged
merged 4 commits into from
Feb 21, 2023

Conversation

liuwuliuyun
Copy link
Contributor

Fixes #20503
Add TestAccBatchPool_mountConfigurationAzureBlobFileSystemWithUserAssignedIdentity

@liuwuliuyun liuwuliuyun changed the title azurerm_batch_pool - fix accessingazure_blob_file_system with user_identity assigned. azurerm_batch_pool - fix accessing azure_blob_file_system with user_identity assigned. Feb 20, 2023
@liuwuliuyun
Copy link
Contributor Author

I will provide test evidence after teamcity test run complete.

@liuwuliuyun
Copy link
Contributor Author

image

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @liuwuliuyun but we have some test failures

------- Stdout: -------
=== RUN   TestAccBatchPool_validateResourceFileWithIdentityReference
=== PAUSE TestAccBatchPool_validateResourceFileWithIdentityReference
=== CONT  TestAccBatchPool_validateResourceFileWithIdentityReference
testcase.go:110: Step 1/1 error: Check failed: Check 1/1 error: building client: building test client: building account: could not acquire access token to parse claims: clientCredentialsToken: cannot request token: Post "https://login.microsoftonline.com/*******/oauth2/v2.0/token": read tcp 192.168.22.243:57134->20.190.154.18:443: read: connection reset by peer
--- FAIL: TestAccBatchPool_validateResourceFileWithIdentityReference (582.89s)
FAIL
------- Stdout: -------
=== RUN   TestAccBatchPool_startTask_userIdentity
=== PAUSE TestAccBatchPool_startTask_userIdentity
=== CONT  TestAccBatchPool_startTask_userIdentity
testcase.go:110: Step 1/2 error: Error running post-apply refresh: exit status 1
Error: building account: could not acquire access token to parse claims: clientCredentialsToken: cannot request token: Post "https://login.microsoftonline.com/*******/oauth2/v2.0/token": read tcp 192.168.22.243:57242->20.190.154.18:443: read: connection reset by peer
with provider["registry.terraform.io/hashicorp/azurerm"],
on terraform_plugin_test.tf line 13, in provider "azurerm":
13: provider "azurerm" {
--- FAIL: TestAccBatchPool_startTask_userIdentity (696.32s)
FAIL

@liuwuliuyun
Copy link
Contributor Author

image
Thanks @stephybun for the review, I just rerun the tests and it looks fine. From the error message, I think it could be a temp network problem.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun LGTM 🍜

@stephybun stephybun merged commit e1f142a into hashicorp:main Feb 21, 2023
@github-actions github-actions bot added this to the v3.45.0 milestone Feb 21, 2023
stephybun added a commit that referenced this pull request Feb 21, 2023
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
@liuwuliuyun liuwuliuyun deleted the fix-20503 branch September 19, 2024 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_batch_pool mount azure_blob_file_system fail using identity_id
2 participants