Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_postgresql_flexible_server_configuration - restart server for static parameters #20044

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jan 17, 2023

Service team raised a request to restart server after user sets the static parameters. So I submitted this PR to support it.

image

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @neil-yechenwei
Thanks for this PR. It looks mostly fine to me, but could you add a test that covers the update path you've added to ensure values are updated successfully and as expected?

Thanks!

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Jan 18, 2023

@jackofallops , thanks for your comment. Actually I already added a test case in this PR to cover the logic I added since "cron.max_running_jobs" is static parameter.

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏷️

@katbyte katbyte merged commit 45b39b8 into hashicorp:main Jan 19, 2023
@github-actions github-actions bot added this to the v3.40.0 milestone Jan 19, 2023
katbyte added a commit that referenced this pull request Jan 19, 2023
@github-actions
Copy link

This functionality has been released in v3.40.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants