-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_storage_account
- infrastructure_encryption_enabled
supports premium FileStorage
#20028
Conversation
…rts kind `FileStorage`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @magodo
Thanks for this PR. It looks mostly good, just a couple of minor amendments I'd like you to take a look at in-line below.
Thanks!
@jackofallops Thank you for the review! I've resolved the comments and passed the test: 💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run=TestAccStorageAccount_infrastructureEncryption
=== RUN TestAccStorageAccount_infrastructureEncryptionStorageV2
=== PAUSE TestAccStorageAccount_infrastructureEncryptionStorageV2
=== RUN TestAccStorageAccount_infrastructureEncryptionFileStorage
=== PAUSE TestAccStorageAccount_infrastructureEncryptionFileStorage
=== RUN TestAccStorageAccount_infrastructureEncryptionBlockBlobStorage
=== PAUSE TestAccStorageAccount_infrastructureEncryptionBlockBlobStorage
=== CONT TestAccStorageAccount_infrastructureEncryptionStorageV2
=== CONT TestAccStorageAccount_infrastructureEncryptionBlockBlobStorage
=== CONT TestAccStorageAccount_infrastructureEncryptionFileStorage
--- PASS: TestAccStorageAccount_infrastructureEncryptionFileStorage (153.98s)
--- PASS: TestAccStorageAccount_infrastructureEncryptionBlockBlobStorage (154.02s)
--- PASS: TestAccStorageAccount_infrastructureEncryptionStorageV2 (293.23s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/storage 293.245s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 📂
This functionality has been released in v3.40.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fix #20013
I've also tried the premuim
BlobStorage
, the API returns an error in this case. Interestingly, the Portal allows you to use premiumBlobStorage
and enable the infra encrpytion in the UI, but the request will silently useStorageV2
at the end.Test
💤 TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run=TestAccStorageAccount_infrastructureEncryption === RUN TestAccStorageAccount_infrastructureEncryption === PAUSE TestAccStorageAccount_infrastructureEncryption === CONT TestAccStorageAccount_infrastructureEncryption --- PASS: TestAccStorageAccount_infrastructureEncryption (336.55s) PASS ok github.com/hashicorp/terraform-provider-azurerm/internal/services/storage 336.558s