Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow subscription cancellation to be disabled via a feature flag #19936

Merged
merged 1 commit into from
Sep 5, 2023
Merged

feat: allow subscription cancellation to be disabled via a feature flag #19936

merged 1 commit into from
Sep 5, 2023

Conversation

josh-barker
Copy link
Contributor

@josh-barker josh-barker commented Jan 10, 2023 •
edited
Loading

Resolves #15751

@josh-barker josh-barker marked this pull request as ready for review January 10, 2023 21:42
@josh-barker

This comment was marked as off-topic.

Sign in to view
@josh-barker josh-barker force-pushed the feat/prevent-subscription-cancellation branch 2 times, most recently from 281b347 to ad8f45f Compare July 5, 2023 02:25
@josh-barker josh-barker force-pushed the feat/prevent-subscription-cancellation branch from ad8f45f to 4f3edd9 Compare July 5, 2023 02:32
jackofallops
jackofallops approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @josh-barker - apologies for the long delay on this one, there's been a lot of internal discussion on this one. The change LGTM and we've reached the aagreement that this should be something users can opt out of, so I'm going to approve and merge this feature.

Thanks for the work, and the patience!

@jackofallops jackofallops merged commit 176e498 into hashicorp:main Sep 5, 2023
1 check passed
@github-actions github-actions bot added this to the v3.72.0 milestone Sep 5, 2023
jackofallops added a commit that referenced this pull request Sep 5, 2023
@jackofallops
Update CHANGELOG.md for #19936
5be5b0a
@josh-barker
Copy link
Contributor Author

Hey @jackofallops , no worries. Thanks to you & team for taking the time to discuss and consider it! :)

@josh-barker josh-barker deleted the feat/prevent-subscription-cancellation branch September 7, 2023 00:22
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees

@jackofallops jackofallops

Labels
documentation service/subscription size/M
Projects
None yet
Milestone
v3.72.0
Development

Successfully merging this pull request may close these issues.

azurerm_subscription: prevent cancellation of existing subscriptions on destroy
2 participants
@josh-barker @jackofallops