Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_sentinel_log_analytics_workspace_onboarding #19692

Merged
merged 15 commits into from
Jan 17, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Dec 15, 2022

Test

❯ TF_ACC=1 go test -v ./internal/services/sentinel -run=TestAccSecurityInsightsSentinelOnboardingState -timeout=600m
=== RUN   TestAccSecurityInsightsSentinelOnboardingState_basic
=== PAUSE TestAccSecurityInsightsSentinelOnboardingState_basic
=== RUN   TestAccSecurityInsightsSentinelOnboardingState_ToggleCmkEnabled
=== PAUSE TestAccSecurityInsightsSentinelOnboardingState_ToggleCmkEnabled
=== RUN   TestAccSecurityInsightsSentinelOnboardingState_requiresImport
=== PAUSE TestAccSecurityInsightsSentinelOnboardingState_requiresImport
=== CONT  TestAccSecurityInsightsSentinelOnboardingState_basic
=== CONT  TestAccSecurityInsightsSentinelOnboardingState_requiresImport
=== CONT  TestAccSecurityInsightsSentinelOnboardingState_ToggleCmkEnabled
--- PASS: TestAccSecurityInsightsSentinelOnboardingState_basic (294.44s)
--- PASS: TestAccSecurityInsightsSentinelOnboardingState_requiresImport (361.96s)
--- PASS: TestAccSecurityInsightsSentinelOnboardingState_ToggleCmkEnabled (5564.88s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/sentinel      5564.906s

@ziyeqf ziyeqf changed the title Tengzh/vanguard/sentinel/onboardstates azurerm_sentinel_log_analytics_workspace_onboard - support new resource Dec 15, 2022
@ziyeqf ziyeqf force-pushed the tengzh/vanguard/sentinel/onboardstates branch from f25490a to 0036876 Compare January 9, 2023 02:53
@ziyeqf ziyeqf marked this pull request as ready for review January 10, 2023 10:10
@ziyeqf ziyeqf changed the title azurerm_sentinel_log_analytics_workspace_onboard - support new resource New Resource: azurerm_sentinel_log_analytics_workspace_onboard Jan 10, 2023
@ziyeqf ziyeqf changed the title New Resource: azurerm_sentinel_log_analytics_workspace_onboard New Resource: azurerm_sentinel_log_analytics_workspace_onboarding Jan 13, 2023
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍄

@katbyte katbyte merged commit 259f97c into hashicorp:main Jan 17, 2023
katbyte added a commit that referenced this pull request Jan 17, 2023
@github-actions github-actions bot added this to the v3.40.0 milestone Jan 17, 2023
@ziyeqf ziyeqf deleted the tengzh/vanguard/sentinel/onboardstates branch January 18, 2023 01:34
@github-actions
Copy link

This functionality has been released in v3.40.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants