azurerm_app_configuration - omit no permission error in get soft-deleted

[teowa]

resolves #19605

Omit no permission error in get soft-deleted.

[stephybun]

The feature flag here

terraform-provider-azurerm/internal/services/appconfiguration/app_configuration_resource.go

Line 260 in eb2e4c6

if !meta.(*clients.Client).Features.AppConfiguration.RecoverSoftDeleted {

Needs to wrap the whole retrieval of the deleted configuration stores which begins on line 249

terraform-provider-azurerm/internal/services/appconfiguration/app_configuration_resource.go

Line 249 in eb2e4c6

deletedConfigurationStoresId := deletedconfigurationstores.NewDeletedConfigurationStoreID(subscriptionId, location, name)

[teowa]

@stephybun , thanks for reviewing this. I have modified the code. But I find if move the retrieval of deleted into the features toggle scope, we cannot return the optedOutOfRecoveringSoftDeletedAppConfigurationErrorFmt error when the deleted exists and recover deleted features toggle disabled.

And there is test failure, the App Conf resource creation is failed and should not exist but returned by resource group list API, which might related to #18796

TF_ACC=1 go test -v ./internal/services/appconfiguration -parallel 20 -test.run=TestAccAppConfiguration_softDeleteRecoveryDisabled -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAppConfiguration_softDeleteRecoveryDisabled
=== PAUSE TestAccAppConfiguration_softDeleteRecoveryDisabled
=== CONT  TestAccAppConfiguration_softDeleteRecoveryDisabled
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Resource Group "acctestRG-appconfig-221214143801923073": the Resource Group still contains Resources.
        
        Terraform is configured to check for Resources within the Resource Group when deleting the Resource Group - and
        raise an error if nested Resources still exist to avoid unintentionally deleting these Resources.
        
        Terraform has detected that the following Resources still exist within the Resource Group:
        
        * `/subscriptions/85b3dbca-5974-4067-9669-67a141095a76/resourceGroups/acctestRG-appconfig-221214143801923073/providers/Microsoft.AppConfiguration/configurationStores/testaccappconf221214143801923073`
        
        This feature is intended to avoid the unintentional destruction of nested Resources provisioned through some
        other means (for example, an ARM Template Deployment) - as such you must either remove these Resources, or
        disable this behaviour using the feature flag `prevent_deletion_if_contains_resources` within the `features`
        block when configuring the Provider, for example:
        
        provider "azurerm" {
          features {
            resource_group {
              prevent_deletion_if_contains_resources = false
            }
          }
        }
        
        When that feature flag is set, Terraform will skip checking for any Resources within the Resource Group and
        delete this using the Azure API directly (which will clear up any nested resources).
        
        More information on the `features` block can be found in the documentation:
        https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#features
        
        
--- FAIL: TestAccAppConfiguration_softDeleteRecoveryDisabled (830.13s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-azurerm/internal/services/appconfiguration      830.144s
FAIL
make: *** [GNUmakefile:99: acctests] Error 1

[stephybun]

We should still return an error if the user is missing the necessary permissions for retrieval and is opted into this feature which is enabled by default, the error message should be changed to something like this:

func userIsMissingNecessaryPermission(name, location string) string {
	return fmt.Sprintf(`
An existing soft-deleted App Configuration exists with the Name %q in the location %q, however
the credentials Terraform is using has insufficient permissions to check for an existing soft-deleted App Configuration.
You can opt out of this behaviour by using the "features" block (located within the "provider" block) - more information
can be found here:
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#features
Alternatively you can manually recover this (e.g. using the Azure CLI) and then import
this into Terraform via "terraform import".
`, name, location)
}

[stephybun]

Thanks @teowa, there's a test failure for this service, would you mind fixing it? Once that's done this should be good to go!

------- Stdout: -------
=== RUN   TestAccAppConfigurationKeysDataSource_allkeys
=== PAUSE TestAccAppConfigurationKeysDataSource_allkeys
=== CONT  TestAccAppConfigurationKeysDataSource_allkeys
testcase.go:110: Step 1/1 error: Error running apply: exit status 1
Error: checking for presence of existing Key: Configuration Store Id "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230118072400473047/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230118072400473047" / Label "label1" / Key "key1": appconfiguration.BaseClient#GetKeyValue: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error: EOF
with azurerm_app_configuration_key.test,
on terraform_plugin_test.tf line 44, in resource "azurerm_app_configuration_key" "test":
44: resource "azurerm_app_configuration_key" "test" {
checking for presence of existing Key: Configuration Store Id
"/subscriptions/*******/resourceGroups/acctestRG-appconfig-230118072400473047/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230118072400473047"
/ Label "label1" / Key "key1": appconfiguration.BaseClient#GetKeyValue:
Failure responding to request: StatusCode=403 -- Original Error:
autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error:
EOF
Error: checking for presence of existing Key: Configuration Store Id "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230118072400473047/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230118072400473047" / Label "label2" / Key "key1": appconfiguration.BaseClient#GetKeyValue: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error: EOF
with azurerm_app_configuration_key.test2,
on terraform_plugin_test.tf line 52, in resource "azurerm_app_configuration_key" "test2":
52: resource "azurerm_app_configuration_key" "test2" {
checking for presence of existing Key: Configuration Store Id
"/subscriptions/*******/resourceGroups/acctestRG-appconfig-230118072400473047/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230118072400473047"
/ Label "label2" / Key "key1": appconfiguration.BaseClient#GetKeyValue:
Failure responding to request: StatusCode=403 -- Original Error:
autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error:
EOF

[katbyte]

Still have test failures:

------- Stdout: -------
=== RUN   TestAccAppConfigurationKeysDataSource_allkeys
=== PAUSE TestAccAppConfigurationKeysDataSource_allkeys
=== CONT  TestAccAppConfigurationKeysDataSource_allkeys
    testcase.go:110: Step 1/1 error: Error running apply: exit status 1
        
        Error: checking for presence of existing Key: Configuration Store Id "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230130193705070873/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230130193705070873" / Label "label1" / Key "key1": appconfiguration.BaseClient#GetKeyValue: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error: EOF
        
          with azurerm_app_configuration_key.test,
          on terraform_plugin_test.tf line 44, in resource "azurerm_app_configuration_key" "test":
          44: resource "azurerm_app_configuration_key" "test" {
        
        checking for presence of existing Key: Configuration Store Id
        "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230130193705070873/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230130193705070873"
        / Label "label1" / Key "key1": appconfiguration.BaseClient#GetKeyValue:
        Failure responding to request: StatusCode=403 -- Original Error:
        autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error:
        EOF
        
        Error: checking for presence of existing Key: Configuration Store Id "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230130193705070873/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230130193705070873" / Label "label2" / Key "key1": appconfiguration.BaseClient#GetKeyValue: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error: EOF
        
          with azurerm_app_configuration_key.test2,
          on terraform_plugin_test.tf line 52, in resource "azurerm_app_configuration_key" "test2":
          52: resource "azurerm_app_configuration_key" "test2" {
        
        checking for presence of existing Key: Configuration Store Id
        "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230130193705070873/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230130193705070873"
        / Label "label2" / Key "key1": appconfiguration.BaseClient#GetKeyValue:
        Failure responding to request: StatusCode=403 -- Original Error:
        autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error:
        EOF
        
        Error: checking for presence of existing Key: Configuration Store Id "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230130193705070873/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230130193705070873" / Label "testlabel" / Key "key2": appconfiguration.BaseClient#GetKeyValue: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error: EOF
        
          with azurerm_app_configuration_key.test3,
          on terraform_plugin_test.tf line 60, in resource "azurerm_app_configuration_key" "test3":
          60: resource "azurerm_app_configuration_key" "test3" {
        
        checking for presence of existing Key: Configuration Store Id
        "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230130193705070873/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230130193705070873"
        / Label "testlabel" / Key "key2": appconfiguration.BaseClient#GetKeyValue:
        Failure responding to request: StatusCode=403 -- Original Error:
        autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error:
        EOF
        
        Error: checking for presence of existing Key: Configuration Store Id "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230130193705070873/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230130193705070873" / Label "testlabel" / Key "key3": appconfiguration.BaseClient#GetKeyValue: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error: EOF
        
          with azurerm_app_configuration_key.test4,
          on terraform_plugin_test.tf line 68, in resource "azurerm_app_configuration_key" "test4":
          68: resource "azurerm_app_configuration_key" "test4" {
        
        checking for presence of existing Key: Configuration Store Id
        "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230130193705070873/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230130193705070873"
        / Label "testlabel" / Key "key3": appconfiguration.BaseClient#GetKeyValue:
        Failure responding to request: StatusCode=403 -- Original Error:
        autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error:
        EOF
        
        Error: checking for presence of existing Key: Configuration Store Id "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230130193705070873/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230130193705070873" / Label "" / Key "key3": appconfiguration.BaseClient#GetKeyValue: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error: EOF
        
          with azurerm_app_configuration_key.test5,
          on terraform_plugin_test.tf line 76, in resource "azurerm_app_configuration_key" "test5":
          76: resource "azurerm_app_configuration_key" "test5" {
        
        checking for presence of existing Key: Configuration Store Id
        "/subscriptions/*******/resourceGroups/acctestRG-appconfig-230130193705070873/providers/Microsoft.AppConfiguration/configurationStores/testacc-appconf230130193705070873"
        / Label "" / Key "key3": appconfiguration.BaseClient#GetKeyValue: Failure
        responding to request: StatusCode=403 -- Original Error: autorest/azure:
        error response cannot be parsed: {"" '\x00' '\x00'} error: EOF
--- FAIL: TestAccAppConfigurationKeysDataSource_allkeys (97.43s)
FAIL

[stephybun]

@teowa any update on this?

[teowa]

The PR should be OK, the failed test is related to #20324

[katbyte]

the tests are still failing:

[katbyte]

@brental - while the GH CI is passing the acctests are failing stil.

@teowa - we are still seeing a test failure:

------- Stdout: -------
=== RUN   TestAccAppConfiguration_softDeletePurgeThenRecreate
=== PAUSE TestAccAppConfiguration_softDeletePurgeThenRecreate
=== CONT  TestAccAppConfiguration_softDeletePurgeThenRecreate
    testcase.go:110: Step 4/5 error: Error running apply: exit status 1
        
        Error: creating Configuration Store (Subscription: "*******"
        Resource Group Name: "acctestRG-appconfig-230320083720637210"
        Configuration Store Name: "testaccappconf230320083720637210"): polling after Create: Code="NameUnavailable" Message="The specified name is already in use." AdditionalInfo=[{"info":{"activityId":"c857dfe2-fe66-4c04-b2bc-04839b5b19d0"},"type":"ActivityId"}]
        

[teowa]

Fixing of the failed test TestAccAppConfiguration_softDeletePurgeThenRecreate is blocked by hashicorp/pandora#1373

[stephybun]

@teowa this should have been unblocked by hashicorp/pandora#2363

[teowa]

HI @stephybun , I have submit another PR #21750 to fix the failed test case.

[ahmar-husain]

Does anyone know, when this PR will be merged?

[stephybun]

@teowa looks like a rebase is required

------- Stdout: -------
=== RUN   TestAccAppConfiguration_softDeletePurgeThenRecreate
=== PAUSE TestAccAppConfiguration_softDeletePurgeThenRecreate
=== CONT  TestAccAppConfiguration_softDeletePurgeThenRecreate
testcase.go:110: Step 4/5 error: Error running apply: exit status 1
Error: creating Configuration Store (Subscription: "*******"
Resource Group Name: "acctestRG-appconfig-230601085823840487"
Configuration Store Name: "testaccappconf230601085823840487"): polling after Create: internal-error: a polling status of `Failed` should be surfaced as a PollingFailedError
with azurerm_app_configuration.test,
on terraform_plugin_test.tf line 26, in resource "azurerm_app_configuration" "test":
26: resource "azurerm_app_configuration" "test" {
--- FAIL: TestAccAppConfiguration_softDeletePurgeThenRecreate (659.92s)
FAIL

[stephybun]

Tests are passing now, thanks @teowa LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.