Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug:] azurerm_cdn_frontdoor_firewall_policy - allow Log as a valid value for managed rule override action in DRS 2.0 and above #19637

Merged
merged 2 commits into from
Dec 12, 2022
Merged

[Bug:] azurerm_cdn_frontdoor_firewall_policy - allow Log as a valid value for managed rule override action in DRS 2.0 and above #19637

merged 2 commits into from
Dec 12, 2022

Conversation

WodansSon
Copy link
Collaborator

(fixes #19561)

@WodansSon WodansSon added this to the v3.36.0 milestone Dec 9, 2022
@github-actions github-actions bot added the size/M label Dec 9, 2022
@WodansSon
Copy link
Collaborator Author

image

katbyte
katbyte approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌳

@katbyte katbyte merged commit 762f080 into main Dec 12, 2022
@katbyte katbyte deleted the b_cdn_frontdoor_rule_override_log branch December 12, 2022 08:06
WodansSon added a commit that referenced this pull request Dec 13, 2022
@WodansSon
updating to include #19637
4b7e514
@github-actions
Copy link

This functionality has been released in v3.36.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@WodansSon @favoretti
[Bug:] azurerm_cdn_frontdoor_firewall_policy - allow Log as a val…
2bc4adf 
…id value for managed rule override `action` in DRS 2.0 and above (hashicorp#19637)
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@WodansSon @favoretti
updating to include hashicorp#19637
bb3dd47
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug documentation service/cdn size/M
Projects
None yet
Milestone
v3.36.0
Development

Successfully merging this pull request may close these issues.

azurerm_cdn_frontdoor_firewall_policy: Action type Log not available for DRS 2.1
2 participants
@WodansSon @katbyte