Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_virtual_machine - support manual schedule days_of_week #19553

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Dec 5, 2022

Close #17931
Adding support for scheduled days when backup frequency is Weekly
days_of_week is sorted automatically at service side so using TypeSet

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Dec 5, 2022

Test result
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍄

@katbyte katbyte merged commit e28e81b into hashicorp:main Dec 5, 2022
katbyte added a commit that referenced this pull request Dec 5, 2022
@github-actions github-actions bot added this to the v3.35.0 milestone Dec 5, 2022
@myc2h6o myc2h6o deleted the sqlvm_days_of_week branch December 6, 2022 00:25
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for [sqlvm] manual backup backup schedule
2 participants