Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_web_application_firewall_policy - Support rule for rule_group_override #19497

Merged
merged 4 commits into from
Dec 14, 2022
Merged

azurerm_web_application_firewall_policy - Support rule for rule_group_override #19497

merged 4 commits into from
Dec 14, 2022

Conversation

ms-zhenhua
Copy link
Contributor

@ms-zhenhua ms-zhenhua commented Nov 30, 2022 •
edited
Loading

fix #19347

image

@ms-zhenhua ms-zhenhua requested a review from katbyte December 6, 2022 01:15
katbyte
katbyte approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from 1 comment LGTM @ms-zhenhua 🦀

website/docs/r/web_application_firewall_policy.html.markdown Outdated Show resolved Hide resolved
katbyte
katbyte requested changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we fix ci? @ms-zhenhua

@ms-zhenhua
Copy link
Contributor Author

could we fix ci? @ms-zhenhua

Seems the lint error is caused by #19569

@ms-zhenhua ms-zhenhua requested a review from katbyte December 14, 2022 01:58
@ms-zhenhua
Copy link
Contributor Author

could we fix ci? @ms-zhenhua

Hi @katbyte, the ci has been fixed. Kindly help review it again. Thanks. 😊

katbyte
katbyte approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏷️

@katbyte katbyte merged commit aa2165b into hashicorp:main Dec 14, 2022
katbyte added a commit that referenced this pull request Dec 14, 2022
@katbyte
CHANGELOG #19497
25e02fe
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@ms-zhenhua @favoretti
azurerm_web_application_firewall_policy - Support rule for `rule_…
8bdf55c 
…group_override` (hashicorp#19497)

Co-authored-by: kt <[email protected]>
fix hashicorp#19347
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@katbyte @favoretti
CHANGELOG hashicorp#19497
9344c03
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/network size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for WAF Policy Rule Group Override
2 participants
@ms-zhenhua @katbyte