Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_route_map #19402

Merged
merged 8 commits into from
Dec 12, 2022
Merged

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Nov 23, 2022

This PR is to support new resource azurerm_route_map.

--- PASS: TestAccRouteMap_basic (2037.04s)
--- PASS: TestAccRouteMap_complete (2114.53s)
--- PASS: TestAccRouteMap_update (2375.27s)
--- PASS: TestAccRouteMap_requiresImport (2588.88s)

@stephybun stephybun self-assigned this Nov 28, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a test failure:

------- Stdout: -------
=== RUN   TestAccRouteMap_update
=== PAUSE TestAccRouteMap_update
=== CONT  TestAccRouteMap_update
    testcase.go:110: Step 1/6 error: Error running pre-apply refresh: exit status 1
        
        Error: The name must begin with a letter, end with a letter or underscore, and may contain only letters, underscores, periods or hyphens. "name": "acctestrm-221205173843714849"
        
          with azurerm_route_map.test,
          on terraform_plugin_test.tf line 39, in resource "azurerm_route_map" "test":
          39:   name           = "acctestrm-221205173843714849"
        
--- FAIL: TestAccRouteMap_update (2.97s)
FAIL

@neil-yechenwei
Copy link
Contributor Author

@katbyte , updated tc. Now all TCs passed.

image

@neil-yechenwei
Copy link
Contributor Author

Resolved conflict.

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💾

@katbyte katbyte merged commit e6d1b9d into hashicorp:main Dec 12, 2022
katbyte added a commit that referenced this pull request Dec 12, 2022
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants