azurerm_kubernetes_cluster: Support for CSI arguments

[CorrenSoft]

May solve #19235

Added 3 optional properties and an optional block (because the disk driver has an additional parameter to specify the version).

Example of implementation:

resource "azurerm_kubernetes_cluster" "aks" {
   
  ...

  storage_disk_driver {
    enabled = true
    version = "V1"
  }
  storage_blob_driver         = true
  storage_file_driver         = false
  storage_snapshot_controller = false
}

Considering the SDK's Object Model, I have two questions on my mind, and I would like to have some feedback:
1- Should all be blocks instead of properties, to allow easy expansion if in the future extra fields are added?
2- Should be all this encapsulated in a single block instead of individual components?

Note: The docs are yet to be updated, will do so upon receiving feedback on the code.

[stevehipwell]

@CorrenSoft I can confirm that this PR would resolve #19235.

My suggestion would be to use blocks and to potentially use a primary storage block to wrap the other ones.

Also is there a reason why you're using V1 instead of v1 for the version?

[stephybun]

Thanks for this PR @CorrenSoft, this is off to a great start!

As suggested by @stevehipwell, I think these would benefit from being grouped into a block called storage_profile. I also left a few more comments in-line regarding the property names and the property enabled which we don't typically expose in Terraform.

Other than that as you've mentioned the docs need to be updated, and we also need to add some tests around this.

[CorrenSoft]

@stevehipwell, I've used V1 because that was the value that I got when I read it from an existing cluster, and also because in any reference that I could find about the valid values they were in uppercase.

@stephybun, thanks for the feedback :)
Just to confirm that I am properly understanding, you are saying that the implementation should be like this:

storage_profile {
  blob__driver_enabled        = true
  disk_driver_enabled         = true
  disk_driver_version         = "V1"
  file_driver_enabled         = false
  snapshot_controller_enabled = false
}

[stephybun]

@CorrenSoft that's correct 🙂

[stevehipwell]

@CorrenSoft I'd suggest that v1 works better for the Terraform API version as it's the industry wide idiomatic representation of a version. @stephybun is there a convention for this provider or Terraform in general which applies to this scenario?

[CorrenSoft]

@stevehipwell I changed the values to v1 and v2. In any case, values are not case-sensitive.

@stephybun I completed the refactor, updated the docs and added a new test (creates cluster with values different from default). Let me know if anything else is needed.

Note: Still running the Acc Tests.

[stephybun]

Thanks for making those changes @CorrenSoft and for touching up the docs! The tests are currently running but I don't expect any issues, aside from the few comments left in-line I have one more question which is, are these properties actually updateable?

[stephybun]

@stevehipwell the convention in the AzureRM provider is to use whatever casing is specified in the API spec/enums provided by Azure. Since there are none for these and the API seems to accept both upper and lower casing I would agree with you that we should go with the industry wide convention for representing versions.

As an aside in the swagger they used lower case v1 in the description.

[stevehipwell]

@stevehipwell the convention in the AzureRM provider is to use whatever casing is specified in the API spec/enums provided by Azure. Since there are none for these and the API seems to accept both upper and lower casing I would agree with you that we should go with the industry wide convention for representing versions.

As an aside in the swagger they used lower case v1 in the description.

They used lowercase in the docs too but we've all been caught out by mixed case sensitivity in Azure.

[CorrenSoft]

I have one more question which is, are these properties actually updateable?

Yes, all of them. The only catch is if you try to use the v2 for the disk version because a preview feature is required (already included a note in the doc).

[stephybun]

Great work on this, thanks @CorrenSoft. LGTM 💯

[github-actions]

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.