Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source - azurerm_lb_outbound_rule #19345

Merged
merged 7 commits into from
Dec 15, 2022

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Nov 17, 2022

Fixes #19301

  • Acceptance Tests
  • Docs
  • Validate specific API for outbound rules

@katbyte
Copy link
Collaborator

katbyte commented Dec 12, 2022

👋 hey @aristosvo - just wondering if your still working on this?

@aristosvo aristosvo marked this pull request as ready for review December 15, 2022 19:20
@aristosvo aristosvo force-pushed the lb/outbound-rule-data-source branch from dabddc7 to 2e46418 Compare December 15, 2022 19:55
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you are thanks for finishing it! LGTM ♻️

@katbyte katbyte merged commit f14017b into hashicorp:main Dec 15, 2022
katbyte added a commit that referenced this pull request Dec 15, 2022
@ElvenSpellmaker
Copy link
Contributor

Nice one thanks for this @aristosvo! =D

favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for getting SNAT Ports from Load Balancer/AKS (data "azurerm_lb_outbound_rule")
3 participants