New Resource: azurerm_lab_service_plan

[neil-yechenwei]

This PR is to support new resource azurerm_lab_service_lab_plan.

[neil-yechenwei]

@stephybun , thanks for your comment. I've updated code. Please take another look. Thanks.

[stephybun]

Test failure

------- Stdout: -------
=== RUN   TestAccLabServicePlan_update
=== PAUSE TestAccLabServicePlan_update
=== CONT  TestAccLabServicePlan_update
=== CONT  TestAccLabServicePlan_update
testcase.go:110: Step 3/4 error: Error running apply: exit status 1
Error: updating Lab Plan (Subscription: "*******"
Resource Group Name: "acctestRG-lslp-221213171606146854"
Lab Plan Name: "acctest-lslp-221213171606146854"): performing CreateOrUpdate: labplan.LabPlanClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="ValidationError" Message="The request is not valid." Details=[{"additionalInfo":[],"details":[],"message":"Property value must be a subset of supported regions: australiaeast, australiasoutheast, brazilsouth, canadacentral, canadaeast, centralindia, centralus, eastasia, eastus, eastus2, eastus2euap, francecentral, germanywestcentral, japaneast, koreacentral, northcentralus, northeurope, norwayeast, southafricanorth, southcentralus, southeastasia, switzerlandnorth, uaenorth, uksouth, ukwest, westcentralus, westeurope, westus","target":"properties.allowedRegions[1]"}] AdditionalInfo=[]
with azurerm_lab_service_plan.test,
on terraform_plugin_test.tf line 69, in resource "azurerm_lab_service_plan" "test":
69: resource "azurerm_lab_service_plan" "test" {
updating Lab Plan (Subscription: "*******"
Resource Group Name: "acctestRG-lslp-221213171606146854"
Lab Plan Name: "acctest-lslp-221213171606146854"): performing CreateOrUpdate:
labplan.LabPlanClient#CreateOrUpdate: Failure sending request: StatusCode=0
-- Original Error: Code="ValidationError" Message="The request is not valid."
Details=[{"additionalInfo":[],"details":[],"message":"Property value must be
a subset of supported regions: australiaeast, australiasoutheast,
brazilsouth, canadacentral, canadaeast, centralindia, centralus, eastasia,
eastus, eastus2, eastus2euap, francecentral, germanywestcentral, japaneast,
koreacentral, northcentralus, northeurope, norwayeast, southafricanorth,
southcentralus, southeastasia, switzerlandnorth, uaenorth, uksouth, ukwest,
westcentralus, westeurope, westus","target":"properties.allowedRegions[1]"}]
AdditionalInfo=[]
--- FAIL: TestAccLabServicePlan_update (276.43s)

[neil-yechenwei]

@stephybun , seems the secondary test location in your test environment is incorrect. Could you check if your secondary test location is correct? If not, please rerun test case after the secondary test location is set correctly in your test environment. Thanks.

[stephybun]

It's running in teamcity with the following values for locations

Tests passed on 5th Dec using the same values and now they're failing.

[neil-yechenwei]

Hi @stephybun , not all locations support lab service. So I limited the test location in service.kt(https://github.com/hashicorp/terraform-provider-azurerm/pull/19312/files#diff-c9a4f5ece9fe921f274cae0220ba39a13027c503c6bd80e3cc9ee926565a5c94) for Teamcity. But seems the change in service.kt doesn't take effect in Teamcity. May I ask when the change in service.kt would take effect? If the change in service.kt would take effect after PR merge, I assume test case failing is expected.

Hence, for now I tried to set env variable env.ARM_PROVIDER_DYNAMIC_TEST to false in Teamcity and all TCs passed. For example, TCs can pass on 5th Dec since this run is with this additional env variable. I just now reran TCs with this variable in Teamcity and all TCs passed.

[stephybun]

Have another comment on the schema while I was going through the docs.

[stephybun]

disconnect_delay, idle_delay and no_connect_delay only come into effect when their corresponding flag is set to true i.e.shutdown_on_disconnect_enabled, shutdown_when_not_connected_enabled and shutdown_on_idle which seems redundant and like a bit of a janky user experience.

disconnect_delay, idle_delay and no_connect_delay should become Optional, and if they are set then they are enabled, if they are absent then they are disabled instead of having to specify that with an additional property.

[neil-yechenwei]

@stephybun , yes, you're right. For shutdown_on_disconnect_enabled and shutdown_when_not_connected_enabled, I've removed them to improve user experience. For shutdown_on_idle, we may not remove it since it's enum value.

The test result after rerun for this new update:

[katbyte]

@neil-yechenwei - settings.kt will only take affect once the PR is merged into main, until then its required to manually change the params on the build

[stephybun]

Thanks @neil-yechenwei LGTM 🥟

[github-actions]

This functionality has been released in v3.37.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.